Frontend: Implement "Submit Bid" Modal - #247
Closed
Johnpii1 wants to merge 10 commits into
Closed
Conversation
feat(web): implement Submit Bid modal with validation, async state, and ErrorBoundary
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
soomtochukwu
requested changes
Apr 24, 2026
soomtochukwu
left a comment
soomtochukwu
left a comment
Contributor
There was a problem hiding this comment.
Pls make sure that the CI checks pass
…32y1ci Add Submit Bid modal with validation, query client, and error boundary; wire into job details
Removed TypeScript checking and updated coverage configuration.
Modify vitest.config.ts for coverage and alias
fix: resolve CI lint error in query-client useQuery implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #133
Description
Add a reusable SubmitBidModal component that implements a mobile-first, accessible dialog with keyboard/focus semantics, clear hover/focus/active states, and async loading feedback (apps/web/components/jobs/submit-bid-modal.tsx).
Introduce strict Zod validation and a payload builder via submitBidSchema and buildBidProposalPayload (apps/web/lib/validation/submit-bid.ts) and unit tests for validation and payload formatting (apps/web/lib/validation/submit-bid.test.ts).
Wire QueryClientProvider at the app level and use query/mutation hooks inside the modal for wallet lookup and bid submission (apps/web/components/providers.tsx and modal usage of useQuery/useMutation).
Replace the inline proposal form on the job details page with the modal wrapped in a component-level ErrorBoundary and add associated tests for modal behavior (apps/web/app/jobs/[id]/page.tsx, apps/web/components/error-boundary.tsx, apps/web/components/jobs/submit-bid-modal.test.tsx).
Add a local shim package to satisfy @tanstack/react-query hooks in this environment when registry installs were blocked, and update tsconfig/Vitest aliases to resolve it (packages/react-query/*, apps/web/tsconfig.json, apps/web/vitest.config.ts).
Testing
npm --prefix apps/web run lint executed and passed (one unrelated pre-existing ESLint warning reported).
Unit tests for the new schema and modal were added (apps/web/lib/validation/submit-bid.test.ts, apps/web/components/jobs/submit-bid-modal.test.tsx) but running npm --prefix apps/web run test -- submit-bid failed in this environment because vitest was not available (error: vitest: not found).
The code was type-checked via existing TypeScript config updates and test coverage targets were updated in vitest.config.ts (no coverage run completed due to the missing test runner).