fix: stop electron-builder from auto-publishing on tag push#10
Merged
Conversation
electron-builder auto-detects a git tag and tries to publish straight to GitHub itself when it sees one, which needs its own GH_TOKEN and isn't configured - it was stepping on the separate softprops/action-gh-release step that already handles publishing. Pass --publish never so it only builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.0.1 release workflow run failed at the last step: electron-builder auto-detects a pushed git tag and tries to publish directly to GitHub itself, which needs its own `GH_TOKEN` that isn't configured (publishing is handled by the separate `softprops/action-gh-release` step). Passes `--publish never` so electron-builder only builds; the existing publish step still attaches the artifacts.
The actual NSIS build itself succeeded fully in that run - this only blocked the final publish step.
Test plan