Fix light tile bug + clean up texture binding #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bindful texture mode the wrong image was being used for the depth image: depthtile1RenderImage instead of the intended depthtile2RenderImage. Fixes DaemonEngine#1734.
VReaperV
reviewed
Aug 21, 2025
Mistakes with texture binding that didn't break anything: - Heat haze doesn't really use height map - 2 shaders used the wrong uniform name when attempting to assign a texture uniform to unit 0, but unit 0 is the default so it didn't matter.
SetShaderProgramUniforms is an overridable function of GLShader used to configure texture mapping units. Material system implies bindless textures meaning TMUs are not used, so material system shaders should not implement that function.
VReaperV
reviewed
Aug 21, 2025
This shader has hard-coded texture unit bindings in the GLSL, so setting uniforms has no effect.
VReaperV
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1734.