[leebeanbin] WEEK 01 Solution #1674
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Jul 21, 2025
Comment on lines
+12
to
+16
| if(nums.length != arr.size()){ | ||
| answer = true; | ||
| } | ||
|
|
||
| return answer; |
There was a problem hiding this comment.
answer 사용의 목적이 nums.length != arr.size() 확인 용도라면 비교문 자체를 return해도 괜찮지 않을까요? return nums.length == arr.size(); 같이요!
TonyKim9401
reviewed
Jul 21, 2025
two-sum/leebeanbin.java
Outdated
There was a problem hiding this comment.
brute force와 map 사용 모두 잘 해주셨네요!
시간, 공간 복잡도도 계산해 주시면 좋을것 같습니다 :)
There was a problem hiding this comment.
위 부분은 어떤식으로 하면 될까요??? BigO 표기법 사용이 맞나요??
There was a problem hiding this comment.
넵넵 BigO 표기법 사용해 주시면 됩니다!
leebeanbin
requested review from
jeongyunjae and
soobing
and removed request for
soobing and
jeongyunjae
|
Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!