Skip to content

[reach0908] WEEK 01 solutions #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 27, 2025
Merged

[reach0908] WEEK 01 solutions #1685

merged 6 commits into from
Jul 27, 2025

Conversation

reach0908
Copy link
Contributor

@reach0908 reach0908 commented Jul 21, 2025

답안 제출 문제

작성자 체크 리스트

  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

검토자 체크 리스트

Important

본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!

  • 바로 이전에 올라온 PR에 본인을 코드 리뷰어로 추가해주세요.
  • 본인이 검토해야하는 PR의 답안 코드에 피드백을 주세요.
  • 토요일 전까지 PR을 병합할 수 있도록 승인해주세요.

@reach0908 reach0908 self-assigned this Jul 21, 2025
@github-actions github-actions bot added the js label Jul 21, 2025
@reach0908 reach0908 changed the title solve: contains-duplicate [reach0908] WEEK 01 solutions Jul 21, 2025
@jun0811 jun0811 self-requested a review July 21, 2025 08:54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 푸신 것 같습니다

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가독성있게 잘 하신 것 같습니다

hashMap.set(nums[i], i);
}

return [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 무조건 하나의 유효값이 있다 해서 예외처리를 안했는데, 이렇게 하는 것도 디테일이라고 생각이 드네요. 좋은 것 같습니다 :)

*/
const longestConsecutive = function (nums) {
if (nums.length === 0) return 0;
const sortedNums = [...new Set(nums)].sort((a, b) => a - b);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정렬이 꼭 필요한 문제는 아니라고 생각이 듭니다. 정렬을 쓰면 nlogn으로 시간복잡도가 올라가니깐 정렬 없는 풀이도 한번 생각해보시면 도움이 될 거 같습니다 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 문제 한번 개선해보고 있습니다!

@reach0908 reach0908 moved this from Solving to In Review in 리트코드 스터디 5기 Jul 26, 2025
@reach0908 reach0908 merged commit be68f4a into DaleStudy:main Jul 27, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Review to Completed in 리트코드 스터디 5기 Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants