feat: publish main-flavor zfs akmods from this fork - #1
Conversation
Enable this fork to actually publish the akmods images zfs-aurora-complex depends on, rather than having that repo rebuild the ZFS akmod from this repo's source on every run. - images.yaml: point the `akmods-base` anchor at `org: danathar`. Left at `ublue-os` the registry rejects a push from this fork with 403. - images.yaml: merge `*server-build-group-only-x86` into `43.main` and `44.main`, adding a `zfs` target alongside common/nvidia-lts/nvidia-open. Upstream builds zfs only for the server flavors, but Aurora DX rides the Fedora `main` kernel. - images.yaml: set `zfs.main.linux_experimental: true`. OpenZFS 2.4.3 caps at kernel 7.0 and F44's main kernel is 7.1.x, so configure fails without it. Same override coreos-testing already carries. - Regenerate build-akmods-main.yml via `just generate-workflows` (schedule minute kept at its existing value to avoid unrelated churn). Also add FORK-PATCHES.md, a registry of every deliberate delta against ublue-os/akmods, split into permanent fork identity and temporary workarounds with a stated removal condition for each. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b68b856e15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ### P3 — Fork README | ||
|
|
||
| - **Files:** `README.md` | ||
| - **What:** fork banner, rationale, and `ghcr.io/danathar/...` pull examples in place of `ghcr.io/ublue-os/...`. |
There was a problem hiding this comment.
Remove the nonexistent fork README patch
The registry instructs future upstream merges to preserve a fork banner and ghcr.io/danathar/... examples, but the current README.md still has the # ublue-os akmods heading and ghcr.io/ublue-os/... examples. Because this file is intended to be the authoritative checklist for mechanical upstream merges, this false entry can cause maintainers to discard upstream README changes while trying to preserve content that does not exist; either apply the described README customization or replace this entry with the actual README delta.
Useful? React with 👍 / 👎.
P3 described a fork-identity README rewrite (fork banner, "Why This Fork Exists", ghcr.io/danathar examples) as committed fork state. It is not — it exists only as an uncommitted working-tree change. The committed README still carries upstream's `# ublue-os akmods` heading and ghcr.io/ublue-os examples, and its only delta against upstream is the Supply-chain scorecard section. Since this file is meant to be the authoritative checklist for mechanical upstream merges, that entry would have led a maintainer to discard upstream README changes to preserve content that does not exist. P3 now documents the actual delta, with the pending rewrite called out explicitly as not-yet-applied. Reported by chatgpt-codex-connector on #1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
What
Makes this fork publish the akmods images
zfs-aurora-complexneeds, instead of that repo rebuilding the ZFS akmod from this repo's source on every run.org: ublue-os→org: danatharin theakmods-baseanchor. Every image ref is assembled as<registry>/<org>/<name>; left atublue-os,just pushfrom this fork gets a 403.zfstarget added to43.mainand44.mainby merging in the existing*server-build-group-only-x86anchor. Upstream builds zfs only for the server flavors, but Aurora DX rides the Fedoramainkernel. Producesghcr.io/danathar/akmods-zfs:main-43and:main-44.zfs.main.linux_experimental: true. OpenZFS 2.4.3 refuses to configure against a kernel newer than 7.0 and F44'smainkernel is 7.1.x:zfs-aurora-complex's nightly (runs 30148339311, 30192096209). Same overridecoreos-testingalready carries.build-akmods-main.ymlregenerated withjust generate-workflows. The generator randomizes the cron minute on every run, so the schedule was restored to its existing value and the four unrelated flavor workflows reverted — the only real change is the two newbuild-main_*_zfsjobs and their addition to thecheck-main_*gates.FORK-PATCHES.mdadded: a registry of every deliberate delta againstublue-os/akmods, split into permanent fork identity vs. temporary workarounds, each temporary one with a stated removal condition.Caveats
--enable-linux-experimentaldisables an upstream compatibility gate. The module may build and still misbehave against a kernel OpenZFS has not validated. Documented as T2 inFORK-PATCHES.mdwith a removal condition.certs/*.priv.test) and pushed images are not cosign-signed. Noted inFORK-PATCHES.md.Testing
Build MAIN akmodswasdisabled_manually(since the 2026-07-05 scheduled runs hit a transientkojipkgstruncation) and has been re-enabled, so this PR exercises the full matrix. PR runs build and test but skip the push, so this validates the build; publishing requires aworkflow_dispatchonmainafter merge.🤖 Generated with Claude Code