Make the confirm step pasteable and run it from the right branch - #53
Merged
Conversation
Two failures hit while actually following the release procedure.
The line carried a trailing `# → "pin is current."` comment. Interactive zsh
does not treat `#` as a comment -- INTERACTIVE_COMMENTS is off by default --
so pasting it passed the comment to the script as arguments:
homebrew_formula.py: error: unrecognized arguments: # → pin is current.
The expected output is prose now rather than an inline comment. It was the
only such comment in any pasteable block across the docs.
The command was also `git pull` with no branch switch, but step 3 leaves you
on the release branch. Pulling there reports "Already up to date" while the
bot's formula commit sits on main, so --check reads a stale formula and the
whole confirmation is meaningless. It switches to main first, and says why.
Verified by running the corrected sequence from a release branch checkout.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two failures found by actually following the release procedure for v0.9.1.
1. The command was not pasteable
Interactive zsh does not treat
#as a comment —INTERACTIVE_COMMENTSis off by default — so pasting this passed the comment to the script as arguments:The expected output is prose now rather than an inline comment. A scan confirms it was the only such comment in any pasteable block across all five markdown files.
2. It ran on the wrong branch
git pullwith no switch — but step 3 leaves you on the release branch. Pulling there reportsAlready up to datewhile the bot's formula commit sits onmain:So
--checkwould read a stale formula from the release branch and the confirmation would be meaningless — worse than not checking, because it looks like it passed.Now
git switch main && git pull python3 homebrew_formula.py --checkIt should print
Homebrew formula pin is current.Verified by running the corrected sequence from a release-branch checkout: prints exactly that, exit 0.
609 tests pass.
🤖 Generated with Claude Code