Skip to content

Conversation

DanielNoord
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #122 (5f8ed48) into main (689b12a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5f8ed48 differs from pull request most recent head 8aba4ce. Consider uploading reports for the commit 8aba4ce to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        19    -1     
  Lines          475       474    -1     
=========================================
- Hits           475       474    -1     
Impacted Files Coverage Δ
...gformatter/_configuration/boolean_option_action.py 100.00% <ø> (ø)
pydocstringformatter/_formatting/_utils.py 100.00% <ø> (ø)
pydocstringformatter/_utils/exceptions.py 100.00% <ø> (ø)
pydocstringformatter/__init__.py 100.00% <100.00%> (ø)
...tringformatter/_configuration/arguments_manager.py 100.00% <100.00%> (ø)
...ngformatter/_configuration/command_line_parsing.py 100.00% <100.00%> (ø)
...tringformatter/_configuration/formatter_options.py 100.00% <100.00%> (ø)
...ydocstringformatter/_configuration/toml_parsing.py 100.00% <100.00%> (ø)
pydocstringformatter/_configuration/validators.py 100.00% <100.00%> (ø)
pydocstringformatter/_formatting/__init__.py 100.00% <100.00%> (ø)
... and 9 more

@github-actions
Copy link

According to the primer, this change has no effect on the checked open source code. 🤖🎉

@DanielNoord DanielNoord merged commit b37a733 into main Jun 20, 2022
@DanielNoord DanielNoord deleted the private branch June 20, 2022 12:14
from pydocstringformatter.configuration.validators import VALIDATORS
from pydocstringformatter.formatting.base import Formatter
from pydocstringformatter._configuration.validators import VALIDATORS
from pydocstringformatter._formatting.base import Formatter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you don't want to make the Formatter public ? It's what make this extendable :)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to revisit #29 when I'm satisfied with the tool.

There are some last things I'd like to include before a 1.0 release but since those aren't a priority and quite difficult to get right I don't think I'll get to them soon.

After that I want to look at the public API. It's probably easier to do that from an "all private" situation than a "all public" situation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's definitely better than the current pylint deprecation "situation" 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants