-
-
Notifications
You must be signed in to change notification settings - Fork 8
Make everything private #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 19 -1
Lines 475 474 -1
=========================================
- Hits 475 474 -1
|
According to the primer, this change has no effect on the checked open source code. 🤖🎉 |
from pydocstringformatter.configuration.validators import VALIDATORS | ||
from pydocstringformatter.formatting.base import Formatter | ||
from pydocstringformatter._configuration.validators import VALIDATORS | ||
from pydocstringformatter._formatting.base import Formatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you don't want to make the Formatter public ? It's what make this extendable :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to revisit #29 when I'm satisfied with the tool.
There are some last things I'd like to include before a 1.0
release but since those aren't a priority and quite difficult to get right I don't think I'll get to them soon.
After that I want to look at the public API. It's probably easier to do that from an "all private" situation than a "all public" situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's definitely better than the current pylint deprecation "situation" 😄
No description provided.