Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change condition to num_heads >= num_heads_k #1030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

change condition to num_heads >= num_heads_k #1030

wants to merge 1 commit into from

Conversation

xenshinu
Copy link

@xenshinu xenshinu commented Jul 5, 2024

Issue #1029

@xenshinu
Copy link
Author

xenshinu commented Jul 14, 2024 •
edited
Loading

Anyone take a look? This will significantly affect performance.
Profiling with Nsight:
Total time split_forward + combine = 24 us
Screenshot 2024-07-05 at 2 32 10 PM
The original code won't trigger split_kv. No split = 77 us
Screenshot 2024-07-05 at 2 33 53 PM
Significant speedup on small batch size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xenshinu