Draft
Conversation
princepatel1010
approved these changes
May 13, 2024
|
I see Gnosis chain is finally getting official UI on Uni |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uniswap never answered any of our PRs (and closed the main one), so it's not necessarily trivial to add Gnosis Chain to Horswap either.
This PR is still a draft and follows work done on PRs on Uniswap. For reference:
It has a few caveats, as it would require to fork two more packages:
@uniswap/sdk-core: I circumvented this one currently with a hack that is "not that bad" but also not great@uniswap/universal-router-sdk: Probably going to do something similar but haven't looked into that yetI guess longer term the best solution would be to maintain forks for both of these, but that obviously comes with additional maintenance burden. Alternatively we could somewhat hack extensions together like I already did for
@uniswap/sdk-core. Of course we can make those cleaner if that's the chosen solution.Todo:
@uniswap/universal-router-sdkpatch-packagepatch: patches/@uniswap+universal-router-sdk+1.5.6.patch. Not the most maintainable or best long-term solution, but a hack similar to@uniswap/sdk-coreisn't really possible without rewriting half the package or forking it.SHOULD_SHOW_ALERTand add colors as well (presumably?)