Light splat helper refactors#691
Conversation
|
changelog |
Changelog (atleast in TG) arent required if its a non-player facing code change. As the changelog is primarly for the players... |
There was a problem hiding this comment.
I'd argue that none of these should exist since their entire purpose is to ignore edge cases and introduce unpredictable behavior (eg, an abomination can have its primary splat be either Kindred or Garou based only on the mood the code was in)
There was a problem hiding this comment.
We can just make sure they have unique ids then. Let me fix that.
modular_darkpack/modules/vampire_the_masquerade/code/splats/ghoul_splat/ghoul_splat.dm
Outdated
Show resolved
Hide resolved
modular_darkpack/modules/vampire_the_masquerade/code/splats/kindred_splat/kindred_splat.dm
Outdated
Show resolved
Hide resolved
modular_darkpack/modules/werewolf_the_apocalypse/code/splats/fera_splat.dm
Outdated
Show resolved
Hide resolved
modular_darkpack/modules/werewolf_the_apocalypse/code/splats/fera_splat.dm
Outdated
Show resolved
Hide resolved
…o splat_helpers
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
|
this doesn't seem necessary for the 1.0 and will only add more convolution imo |
5 participants
About The Pull Request
Adds logic for getting the "most important" splat on a mob, functionally right now, its the firs full splat you have.
Renames the issplat helpers to be more clear that they are getters instead of returning truth
Why It's Good For The Game
In theory should simplfy some logic if you need to decide a singular splat to use. And some helpers for halfsplat checks if someone finds that useful
issplat is a bit confusing.
Changelog
🆑
refactor: Cleans up some syntax on splat helpers
/:cl: