Skip to content

Biting Tutorial#732

Open
FalloutFalcon wants to merge 4 commits intoDarkPack13:masterfrom
FalloutFalcon:biting-tutorial
Open

Biting Tutorial#732
FalloutFalcon wants to merge 4 commits intoDarkPack13:masterfrom
FalloutFalcon:biting-tutorial

Conversation

@FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Feb 26, 2026

About The Pull Request

2026-02-25.18-01-08.mp4

Why It's Good For The Game

Some people used to click the button but its a keybind now.

Changelog

🆑
add: Adds a tutorial for biting as a Kindred
/:cl:

@FalloutFalcon FalloutFalcon requested a review from a team as a code owner February 26, 2026 00:05

GLOB.kindred_list -= owner

/datum/splat/vampire/kindred/splat_life(seconds_per_tick)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely there's a better way than having a check for this each splat_life() tick???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If u have one ill try it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this how /tg/ handles it???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tg doesnt need to listen to things around it, they just call it directly in the attack_chain code for the hand tutorials lol.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant we instead just trigger it from grabbing an npc, or perhaps when bloodpool enters hungry state via TRAIT_NEEDS_BLOOD so that it isn't running on every life tick?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once it finds and tries an npc once, it wont get past !tutorial_shown so i dont reallllly see the issue tbh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could trigger off of a mob bump, mob grab, or on_gain even, NOT on splat_life

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself.

@github-actions github-actions bot added the Stale label Mar 6, 2026

switch(stage)
if(STAGE_GRAB_VICTIM)
show_instruction("Pull then grab the NPC to regain BP.")
Copy link
Contributor

@buffyuwu buffyuwu Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
show_instruction("Pull then grab the NPC to regain BP.")
show_instruction("Pull the NPC twice to initiate an aggressive grab.")

if(STAGE_PRESS_BITE)
show_instruction(keybinding_message(
/datum/keybinding/human/bite,
"Press '%KEY%' to bite",
Copy link
Contributor

@buffyuwu buffyuwu Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Press '%KEY%' to bite",
"While grabbing, take the NPC somewhere private and press '%KEY%' to bite the NPC. This will start restoring your blood pool.",

if(STAGE_RELEASE_VICTIM)
show_instruction(keybinding_message(
/datum/keybinding/mob/stop_pulling,
"Press '%KEY%' to release to stop feeding!.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Press '%KEY%' to release to stop feeding!.",
"Press '%KEY%' to release your victim and stop feeding.",


GLOB.kindred_list -= owner

/datum/splat/vampire/kindred/splat_life(seconds_per_tick)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could trigger off of a mob bump, mob grab, or on_gain even, NOT on splat_life

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants