Fetch enlightenment directly from path#737
Open
FalloutFalcon wants to merge 7 commits intoDarkPack13:masterfrom
Open
Fetch enlightenment directly from path#737FalloutFalcon wants to merge 7 commits intoDarkPack13:masterfrom
FalloutFalcon wants to merge 7 commits intoDarkPack13:masterfrom
Conversation
chazzyjazzy
requested changes
Feb 27, 2026
modular_darkpack/modules/storyteller_stats/code/st_stats/base_type/_morality.dm
Outdated
Show resolved
Hide resolved
modular_darkpack/modules/storyteller_stats/code/st_stats/base_type/_morality.dm
Outdated
Show resolved
Hide resolved
Contributor
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
…o weird-morality-mistake
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Creates a helper proc to fetch enlightenment from the stat and removes the enlightenment var on splat.
Why It's Good For The Game
More consistent to just directly check a datum rather then the datum having to set a var on a mob. which could be desyned if something else (like the new for kindred splat) sets it.
Changelog
🆑
code: Fetches enlightenment directly from Path.
/:cl: