Reimplements Visceratika by chazzyjazzy · Pull Request #739 · DarkPack13/SecondCity

chazzyjazzy · 2026-02-28T23:26:36Z

About The Pull Request

No flying yet thats a diferent PR since im trying to atomize

Why It's Good For The Game

Gar of the Goyle

Changelog

🆑
add: Reimplements Visceratika

/:cl:

chazzyjazzy · 2026-03-02T19:14:11Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

 	if(isliving(mover))
 		var/mob/living/moving_mob = mover
-		if(HAS_TRAIT(moving_mob, TRAIT_PASS_THROUGH_WALLS) && (get_area(moving_mob) == get_area(src)))
+		if(HAS_TRAIT(moving_mob, TRAIT_PASS_THROUGH_WALLS)/* && (get_area(moving_mob) == get_area(src))*/)


not sure if the area check (gargoyles passing thru walls can only travel thru walls within a particular area, not go from area to area, for ex, they cant go from the sewers into the chantry) is a lore thing or a balance thing so might need a ruling on that...

Balance. It also prevents people from walking out into space/unintended parts of the map. Its kinda required unless we map better.

github-actions · 2026-03-10T01:48:54Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself.

FalloutFalcon · 2026-03-10T23:32:03Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

+	if(level >= 4)
+		owner.physiology.brute_mod *= 0.8
+		owner.physiology.heat_mod *= 0.5
+		//owner.physiology.clone_mod *= 0.9
+		//ADD_TRAIT(owner, TRAIT_IGNOREDAMAGESLOWDOWN, TRAIT_GENERIC)
+		ADD_TRAIT(owner, TRAIT_NOSOFTCRIT, DISCIPLINE_TRAIT)
+		if(!(owner.is_clan(/datum/subsplat/vampire_clan/gargoyle)))
+			ADD_TRAIT(owner, TRAIT_MASQUERADE_VIOLATING_FACE, DISCIPLINE_TRAIT)


In most code rn this is done on the gain of the disc power instead...

FalloutFalcon · 2026-03-10T23:47:42Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

+	if(level >= 4)
+		owner.physiology.brute_mod *= 0.8
+		owner.physiology.heat_mod *= 0.5
+		//owner.physiology.clone_mod *= 0.9


FalloutFalcon · 2026-03-10T23:48:01Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

+		if(!(owner.is_clan(/datum/subsplat/vampire_clan/gargoyle)))
+			ADD_TRAIT(owner, TRAIT_MASQUERADE_VIOLATING_FACE, DISCIPLINE_TRAIT)


I dont see a reason to have a check for gargy here. The point of trait sources is so we can apply them with overlap like this.

FalloutFalcon · 2026-03-10T23:50:48Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

+	for(var/mob/living/player in GLOB.player_list)
+		if(get_area(player) == get_area(owner))
+			var/their_name = player.name
+			if(ishuman(player))
+				var/mob/living/carbon/human/human_player = player
+				their_name = human_player.real_name
+			to_chat(owner, "- [their_name]")


This seems a little unneeded and is represented fine with thermal vision. its also based on area and shows real name for little reason..

FalloutFalcon · 2026-03-10T23:53:20Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

 	if(isliving(mover))
 		var/mob/living/moving_mob = mover
-		if(HAS_TRAIT(moving_mob, TRAIT_PASS_THROUGH_WALLS) && (get_area(moving_mob) == get_area(src)))
+		if(HAS_TRAIT(moving_mob, TRAIT_PASS_THROUGH_WALLS)/* && (get_area(moving_mob) == get_area(src))*/)


Balance. It also prevents people from walking out into space/unintended parts of the map. Its kinda required unless we map better.

FalloutFalcon · 2026-03-11T00:14:18Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

-	ADD_TRAIT(owner, TRAIT_MUTE, STATUE_MUTE)
-	ADD_TRAIT(owner, TRAIT_IMMOBILIZED, MAGIC_TRAIT)
-	ADD_TRAIT(owner, TRAIT_HANDS_BLOCKED, MAGIC_TRAIT)
+	to_chat(owner, span_danger("This is a passive ability. The effects are already active!"))


might be better as just a toggle. otherwise we really need code to just not add true passives to the hud like this.

FalloutFalcon · 2026-03-11T00:14:37Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

+		to_chat(owner, span_warning("Your bond with the nearby stone is interrupted!"))
+		exit_turf = null
+		return FALSE
+	owner.forceMove(stone_turf)


if code works u could step after u add the trait.

FalloutFalcon · 2026-03-11T00:15:33Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

+	var/turf/exit_turf
+	var/turf/stone_turf


with how these are used. they could both be weakrefed pretty easy

FalloutFalcon · 2026-03-11T00:15:51Z

modular_darkpack/modules/powers/code/discipline/visceratika.dm

+/datum/storyteller_roll/scry_the_hearthstone
+	bumper_text = "scry the hearthstone"
+	difficulty = 6
+	applicable_stats = list(STAT_PERCEPTION, STAT_AWARENESS)


Suggested change

/datum/storyteller_roll/scry_the_hearthstone

bumper_text = "scry the hearthstone"

difficulty = 6

applicable_stats = list(STAT_PERCEPTION, STAT_AWARENESS)

/datum/storyteller_roll/scry_the_hearthstone

bumper_text = "scry the hearthstone"

applicable_stats = list(STAT_PERCEPTION, STAT_AWARENESS)

FalloutFalcon · 2026-03-11T00:16:32Z

code/_globalvars/traits/_traits.dm

 		"TRAIT_BLOODY_SUCKER" = TRAIT_BLOODY_SUCKER, // DARKPACK EDIT ADD
 		"TRAIT_BLOOD_DRINKER" = TRAIT_BLOOD_DRINKER, // DARKPACK EDIT ADD
 		"TRAIT_BLUSH_OF_HEALTH" = TRAIT_BLUSH_OF_HEALTH, // DARKPACK EDIT ADD
+		"TRAIT_BOND_WITHIN_THE_MOUNTAIN" = TRAIT_BOND_WITHIN_THE_MOUNTAIN, // DARKPACK EDIT ADD - Visceratika


Suggested change

"TRAIT_BOND_WITHIN_THE_MOUNTAIN" = TRAIT_BOND_WITHIN_THE_MOUNTAIN, // DARKPACK EDIT ADD - Visceratika

"TRAIT_BOND_WITHIN_THE_MOUNTAIN" = TRAIT_BOND_WITHIN_THE_MOUNTAIN, // DARKPACK EDIT ADD - POWERS - (Visceratika)

rei

f46b4f5

github-actions bot added Sound Feature labels Feb 28, 2026

chazzyjazzy added 5 commits March 1, 2026 16:20

ok

51a891f

ok lets redo

461bbe6

ok

50d0f88

bow

7e46d2b

Merge branch 'master' into garg

8545a53

chazzyjazzy commented Mar 2, 2026

View reviewed changes

ti cghat

20b6097

chazzyjazzy marked this pull request as ready for review March 2, 2026 19:15

chazzyjazzy requested a review from a team as a code owner March 2, 2026 19:15

github-actions bot added the Stale label Mar 10, 2026

FalloutFalcon removed the Stale label Mar 10, 2026

FalloutFalcon requested changes Mar 11, 2026

View reviewed changes

		if(!(owner.is_clan(/datum/subsplat/vampire_clan/gargoyle)))
		ADD_TRAIT(owner, TRAIT_MASQUERADE_VIOLATING_FACE, DISCIPLINE_TRAIT)

	"TRAIT_BOND_WITHIN_THE_MOUNTAIN" = TRAIT_BOND_WITHIN_THE_MOUNTAIN, // DARKPACK EDIT ADD - Visceratika
	"TRAIT_BOND_WITHIN_THE_MOUNTAIN" = TRAIT_BOND_WITHIN_THE_MOUNTAIN, // DARKPACK EDIT ADD - POWERS - (Visceratika)

Conversation

chazzyjazzy commented Feb 28, 2026

About The Pull Request

Why It's Good For The Game

Changelog

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants