Makes indexes of stat lists a type rather then string#743
Draft
FalloutFalcon wants to merge 6 commits intoDarkPack13:masterfrom
Draft
Makes indexes of stat lists a type rather then string#743FalloutFalcon wants to merge 6 commits intoDarkPack13:masterfrom
FalloutFalcon wants to merge 6 commits intoDarkPack13:masterfrom
Conversation
…o yet-another-stat-rework
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes indexes of stat holder lists a type rather then string
Why It's Good For The Game
The only place a string was useful was tgui so we do text2path there instead of EVERYWHERE else.
Allows for better handling, as you can access the type directly if you need something like a name, and dont have to wrap all logic on strings which is annoying.
Its a hanger-on from when we were direct saving the list for prefs. this is no longer needed.
Changelog
🆑
code: List index for stats was made its type instead of a type as a string
/:cl: