Skip to content

Makes indexes of stat lists a type rather then string#743

Draft
FalloutFalcon wants to merge 6 commits intoDarkPack13:masterfrom
FalloutFalcon:yet-another-stat-rework
Draft

Makes indexes of stat lists a type rather then string#743
FalloutFalcon wants to merge 6 commits intoDarkPack13:masterfrom
FalloutFalcon:yet-another-stat-rework

Conversation

@FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Mar 6, 2026

About The Pull Request

Makes indexes of stat holder lists a type rather then string

Why It's Good For The Game

The only place a string was useful was tgui so we do text2path there instead of EVERYWHERE else.

Allows for better handling, as you can access the type directly if you need something like a name, and dont have to wrap all logic on strings which is annoying.

Its a hanger-on from when we were direct saving the list for prefs. this is no longer needed.

Changelog

🆑
code: List index for stats was made its type instead of a type as a string
/:cl:

@FalloutFalcon FalloutFalcon requested a review from a team as a code owner March 6, 2026 06:34
@FalloutFalcon FalloutFalcon marked this pull request as draft March 6, 2026 06:39
@FalloutFalcon
Copy link
Member Author

FalloutFalcon commented Mar 6, 2026

Im realizing this seems to be a breaking change for pref. and i will prob want to write an update script for it.... No i think i missed a piece of code is all. why would this break when we still always store as a string. what would i write an update to even fix.
plus imma wait on #738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant