Skip to content

Darkpack versioning for save files#746

Open
FalloutFalcon wants to merge 2 commits intoDarkPack13:masterfrom
FalloutFalcon:darkpack-version-updates
Open

Darkpack versioning for save files#746
FalloutFalcon wants to merge 2 commits intoDarkPack13:masterfrom
FalloutFalcon:darkpack-version-updates

Conversation

@FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Mar 10, 2026

About The Pull Request

Versioning that duplicates the versions for prefs

Why It's Good For The Game

Useful and eaiser to mantain then having to make sure it doesnt conflict with tg version updates

Changelog

🆑
code: Darkpack versioning for preference save files
/:cl:

@FalloutFalcon
Copy link
Member Author

Prefs seem fine and dont seem to explode.
image

@FalloutFalcon FalloutFalcon marked this pull request as ready for review March 10, 2026 20:15
@FalloutFalcon FalloutFalcon requested a review from a team as a code owner March 10, 2026 20:15
// DARKPACK EDIT ADD START
/datum/preferences/proc/update_preferences_darkpack(current_version, datum/json_savefile/S)

/datum/preferences/proc/update_character_darkpack(current_version, list/save_data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wazzup with these empty procs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its future proofing for when we need to update prefs. e.g #745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants