Skip to content

Clean up formatting and require format checks#91

Merged
Darkroom4364 merged 1 commit into
devfrom
issue/89-format-required
May 31, 2026
Merged

Clean up formatting and require format checks#91
Darkroom4364 merged 1 commit into
devfrom
issue/89-format-required

Conversation

@Darkroom4364

@Darkroom4364 Darkroom4364 commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • run gofmt across the server formatting backlog
  • run cargo fmt across the agent formatting backlog
  • promote the Format CI job from advisory to blocking through CI Gate
  • refresh the Foxguard baseline for formatted legacy findings so the required app check blocks only new debt
  • add narrow agent URL/TLS hardening so the formatting diff does not create new high-severity Foxguard findings
  • update development workflow docs to describe the blocking Format suite and Foxguard baseline

Validation

  • gofmt -l server
  • cargo fmt --check
  • npx foxguard@latest diff --format json origin/dev .
  • npx foxguard@latest . --baseline .foxguard/baseline.json --format json
  • go test ./...
  • go vet ./...
  • go build -o /private/tmp/microc2-server-issue89 ./cmd
  • cargo test --locked
  • cargo clippy --locked --all-targets
  • cargo build --locked

Closes #89

@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 27795e83-0ae0-42fa-9235-b9b6654334d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/89-format-required

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Darkroom4364 Darkroom4364 force-pushed the issue/89-format-required branch 2 times, most recently from e517c56 to 9a32fd6 Compare May 31, 2026 18:55
@Darkroom4364 Darkroom4364 force-pushed the issue/89-format-required branch from 9a32fd6 to 42c4c36 Compare May 31, 2026 19:35
@Darkroom4364 Darkroom4364 merged commit 9d1e0a2 into dev May 31, 2026
11 checks passed
@Darkroom4364 Darkroom4364 deleted the issue/89-format-required branch May 31, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant