fix: make bold and italic tags persist after block conversion (text type)#42
Closed
vvidday wants to merge 3 commits intoDashibase:mainfrom
Closed
fix: make bold and italic tags persist after block conversion (text type)#42vvidday wants to merge 3 commits intoDashibase:mainfrom
vvidday wants to merge 3 commits intoDashibase:mainfrom
Conversation
Contributor
Author
|
Apologies, I made a mistake when rebasing so the commit history is unclear. I'll make a new PR with the same changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, converting between text type blocks (text <-> quote / text->text / quote->quote) results in loss of bold and italic tags
Lotion.vue::setBlockTypeto use html content instead of text content when target block is text/quote (solves conversion with no search)Block.vue::clearSearchto take into account html content - now if type of block before conversion is text/quote, it will store the html content in addition to the text content, and if the type of block after conversion is text/quote, it will use the stored html content. (solves conversion via search)video
Tags are still lost when converting to heading types, could potentially find a workaround with the current implementation but @holazz's refactor in #39 will potentially make it much easier (I think we would be able to use the same logic as text blocks)