fix: the read-only button has a lower zindex value#67
Open
knoxnoe wants to merge 2 commits intoDashibase:mainfrom
Open
fix: the read-only button has a lower zindex value#67knoxnoe wants to merge 2 commits intoDashibase:mainfrom
knoxnoe wants to merge 2 commits intoDashibase:mainfrom
Conversation
knoxnoe
commented
Sep 23, 2022
knoxnoe
commented
greentfrapp
requested changes
Oct 7, 2022
src/components/Main.vue
Outdated
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <div class="fixed bottom-4 right-4 bg-neutral-800 font-sans text-white px-4 rounded-lg py-2"> | |||
| <div class="fixed bottom-4 right-4 bg-neutral-800 font-sans text-white px-4 rounded-lg py-2 z-999"> | |||
Contributor
There was a problem hiding this comment.
Let's use z-[99] here instead? That way we don't need to change the tailwind config file.
Contributor
There was a problem hiding this comment.
And we can revert the changes to the tailwind config file
Contributor
|
Hey @yrytiannuo sorry for the late reply! Just took a look at the code and requested some changes (see above!) Thanks for spotting this bug! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.