Skip to content

Comments

Ordered and Unordered List block#73

Open
laurensiusadi wants to merge 2 commits intoDashibase:mainfrom
laurensiusadi:feat-new-blocks
Open

Ordered and Unordered List block#73
laurensiusadi wants to merge 2 commits intoDashibase:mainfrom
laurensiusadi:feat-new-blocks

Conversation

@laurensiusadi
Copy link

image

Attempting to make new feature.

  • New ordered and unordered list block type, which uses TextBlock component plus styling
  • Block split type defaults to current block type (text splits into text, list into list)
  • Backspace on List turns block into Text, another Backspace merge removes the block
  • Ordered list is triggered with 1. , unordered by -

Problem:

  • Ordered list doesn't reset correctly. Since I'm using CSS to achieve showing div as List here list-item list-decimal and list-item list-disc, the page div keeps the counter.
    wrong-counter

Suggestion:

  • Maybe we should attempt to use actual ol ul li tags

@laurensiusadi laurensiusadi mentioned this pull request Feb 26, 2023
@laurensiusadi
Copy link
Author

Numbering now resets correctly.

image

@laurensiusadi laurensiusadi marked this pull request as ready for review June 11, 2023 05:38
@laurensiusadi laurensiusadi changed the title Draft: Ordered and Unordered List block Ordered and Unordered List block Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant