Skip to content

Perform foreign key checks even if empty tables exist ...#190

Closed
nickzoic wants to merge 1 commit into
Data-Liberation-Front:masterfrom
logicly-au:bugfix/foreign-key-checks
Closed

Perform foreign key checks even if empty tables exist ...#190
nickzoic wants to merge 1 commit into
Data-Liberation-Front:masterfrom
logicly-au:bugfix/foreign-key-checks

Conversation

@nickzoic

Copy link
Copy Markdown
Contributor
  • Tables with 0 rows are still valid tables ... mark table valid on seeing header or data row.

  • This was preventing foreign key checks from running if any table was empty because of the
    unless @validated_tables.has_value?(false) in TableGroup.validate_foreign_keys

@coveralls

coveralls commented Nov 16, 2016

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 97.064% when pulling 756d0fd on nickzoic:bugfix/foreign-key-checks into 7780c78 on theodi:master.

@nickzoic

nickzoic commented Dec 9, 2016

Copy link
Copy Markdown
Contributor Author

This is now part of PR #193 so I'm closing this one ...

@nickzoic nickzoic closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants