[Proposed Change] Skip File Ref Validation Logic; Improve Logs #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,8 +41,10 @@ public StepResult doStep(FlightContext context) throws InterruptedException { | |||
| for (Column column : table.getColumns()) { | |||
| if (column.isFileOrDirRef()) { | |||
| List<String> refIdArray = bigQueryDatasetPdao.getRefIds(dataset, stagingTableName, column); | |||
| List<String> badRefIds = fileDao.validateRefIds(dataset, refIdArray); | |||
| badRefIds.forEach(id -> invalidRefIds.add(new InvalidRefId(id, column.getName()))); | |||
| if (!refIdArray.isEmpty()) { | |||
There was a problem hiding this comment.
I think this check should be done inside FireStoreDao.validateRefIds() instead of in the caller, since it's an optimization that method can do regardless of who calls validateRefIds(). It could even be pushed one layer down into FireStoreDirectoryDao.validateRefIds().
There was a problem hiding this comment.
Good point - I've moved it to the directory dao.
snf2ye
force-pushed
the
sh-skip-validation
branch
from
8a3fabc
to
5103579
Compare
snf2ye
changed the title
pshapiro4broad
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There isn't yet a ticket for this work because I'm not sure if we want to make this change. If there is agreement that this change should be made, then can create a ticket!
Background
We were recently trying to figure out what went wrong with a user's ingest request. We encountered a batch of strange-looking logs:
While the logs look strange, they're actually okay. Each log indicates that we are performing a check against a column designated as a fileref. This particular ingest was only ingesting files into a single column. We were left with a wall of unhelpful logs.
Relevant code:
Issues
Proposal