Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Remove customer data track for perf and bundle size #3393

Merged
merged 6 commits into from
Apr 2, 2025

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Mar 5, 2025

Motivation

Customer data tracker can cause performance overhead and we want to decrease bundle size.

Changes

Remove customer data tracker.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@cy-moi cy-moi force-pushed the congyao/perf-friday-delete-customer-data branch from 3be80c5 to 5bade7b Compare March 21, 2025 13:15
@cy-moi cy-moi force-pushed the congyao/perf-friday-delete-customer-data branch from 5bade7b to 19d7208 Compare March 21, 2025 13:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (56030c6) to head (bd8be5d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3393      +/-   ##
==========================================
- Coverage   91.94%   91.90%   -0.04%     
==========================================
  Files         312      311       -1     
  Lines        8122     8034      -88     
  Branches     1837     1819      -18     
==========================================
- Hits         7468     7384      -84     
+ Misses        654      650       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cy-moi cy-moi marked this pull request as ready for review March 21, 2025 13:32
@cy-moi cy-moi requested a review from a team as a code owner March 21, 2025 13:32
Copy link

cit-pr-commenter bot commented Mar 21, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 147.43 KiB 145.35 KiB -2131 B -1.41%
Logs 51.40 KiB 50.16 KiB -1264 B -2.40%
Rum Slim 106.79 KiB 104.80 KiB -2040 B -1.87%
Worker 23.59 KiB 23.59 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.003 0.003 0.001
addaction 0.044 0.070 0.027
addtiming 0.002 0.002 0.001
adderror 0.045 0.076 0.031
startstopsessionreplayrecording 0.010 0.033 0.023
startview 0.431 0.615 0.184
logmessage 0.024 0.043 0.019
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 30.18 KiB 31.13 KiB 973 B
addaction 56.95 KiB 58.78 KiB 1.83 KiB
addtiming 26.89 KiB 26.78 KiB -116 B
adderror 60.07 KiB 61.84 KiB 1.76 KiB
startstopsessionreplayrecording 26.04 KiB 25.64 KiB -412 B
startview 428.28 KiB 428.36 KiB 78 B
logmessage 55.17 KiB 56.90 KiB 1.74 KiB

🔗 RealWorld

@cy-moi cy-moi force-pushed the congyao/perf-friday-delete-customer-data branch from a0abb11 to 61bf80a Compare March 27, 2025 15:32
@cy-moi cy-moi force-pushed the congyao/perf-friday-delete-customer-data branch from 8b25d2f to 63b1efa Compare March 31, 2025 07:49
@cy-moi
Copy link
Contributor Author

cy-moi commented Apr 1, 2025

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Apr 1, 2025

View all feedbacks in Devflow UI.
2025-04-01 13:46:09 UTC ℹ️ Start processing command /to-staging


2025-04-01 13:46:20 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 15m44s (p90)

Commit bd8be5d4ad will soon be integrated into staging-14.


2025-04-01 13:59:12 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit bd8be5d4ad has been merged into staging-14 in merge commit 7e96e9fac3.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-14

dd-mergequeue bot added a commit that referenced this pull request Apr 1, 2025
@dd-devflow dd-devflow bot added the staging-14 label Apr 1, 2025
@cy-moi cy-moi merged commit b1242b2 into main Apr 2, 2025
19 checks passed
@cy-moi cy-moi deleted the congyao/perf-friday-delete-customer-data branch April 2, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants