fix empty secret name behavior and allow reading PKI from disk#3
Merged
Conversation
cahillsf
force-pushed
the
stephen.cahill/fix-tls-generator
branch
from
3bf113c to
b093afd
Compare
This was referenced Feb 26, 2026
Closed
cahillsf
changed the title
cahillsf
changed the title
cahillsf
force-pushed
the
stephen.cahill/fix-tls-generator
branch
5 times, most recently
from
62304b1 to
a1314d1
Compare
7 tasks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Stephen Cahill <stephen.cahill@datadoghq.com>
… guards Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Stephen Cahill <stephen.cahill@datadoghq.com>
cahillsf
force-pushed
the
stephen.cahill/fix-tls-generator
branch
from
a1314d1 to
d5ca3fa
Compare
havenwhitney-dd
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes crossplane#7008
""and this is always assigned as the pointer, the== nilwill never evaluate as true. This fixes that behavior so the controller does not attempt to generate the bundle and populate the secrets if those values are not configured as envvarsSecretCAProvider, adds new functionality underFileCAProviderinitializer.SecretKeyCACert,corev1.TLSCertKey,corev1.TLSPrivateKeyKey) rather than hardcoded string defaultsI have:
./nix.sh flake checkto ensure this PR is ready for review.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Followed the API promotion workflow if this PR introduces, removes, or promotes an API.