Skip to content

Revert "add ecr helper to crossplane" #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cahillsf merged 1 commit into from
Jan 20, 2026
Merged

Revert "add ecr helper to crossplane" #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,35 +45,10 @@ before_script:
-ldflags="-s -w -X=github.com/crossplane/crossplane/v2/internal/version.version=${VERSION}" \
-o crossplane ./cmd/crossplane

# Download ECR credential helper for cloud-native ECR authentication
# TARGETOS and TARGETARCH are automatically set by buildx for multi-platform builds
ARG TARGETOS
ARG TARGETARCH
ARG ECR_HELPER_VERSION=0.11.0
RUN set -ex && \
OS="${TARGETOS:-linux}" && \
ARCH="${TARGETARCH:-amd64}" && \
wget -q -O /usr/local/bin/docker-credential-ecr-login \
"https://amazon-ecr-credential-helper-releases.s3.us-east-2.amazonaws.com/${ECR_HELPER_VERSION}/${OS}-${ARCH}/docker-credential-ecr-login" && \
chmod +x /usr/local/bin/docker-credential-ecr-login

# Create docker config that uses the ECR credential helper for specific ECR registries
RUN mkdir -p /home/nonroot/.docker && \
cat > /home/nonroot/.docker/config.json << 'DOCKERCFG'
{
"credHelpers": {
"727006795293.dkr.ecr.us-east-1.amazonaws.com": "ecr-login"
}
}
DOCKERCFG

FROM registry.ddbuild.io/images/base/gbi-distroless-nossl-root-fips:release
COPY --from=builder /crossplane/crossplane /usr/local/bin/
COPY --from=builder /usr/local/bin/docker-credential-ecr-login /usr/local/bin/
COPY --from=builder /home/nonroot/.docker/config.json /home/nonroot/.docker/config.json
COPY cluster/crds/ /crds
COPY cluster/webhookconfigurations/ /webhookconfigurations
ENV DOCKER_CONFIG=/home/nonroot/.docker
EXPOSE 8080
USER 65532
ENTRYPOINT ["crossplane"]
Expand Down Expand Up @@ -116,4 +91,4 @@ before_script:
echo "Successfully built and pushed ${REGISTRY}/${IMAGE_NAME}:${VERSION}"

crossplane:
extends: .build-crossplane
extends: .build-crossplane