Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependabot): Simplify dependabot configuration #33063

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Jan 17, 2025

What does this PR do?

Remove the duplicate entries for the gomod package ecosystem (except for internal/tools for security reason according to the comment)

Motivation

Improve the capacity from dependabot to keep our dependencies up-to-date with a simpler configuration. Today only few modules are tracked by dependabot
image

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested a review from a team as a code owner January 17, 2025 11:16
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Jan 17, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jan 17, 2025
@chouetz chouetz force-pushed the nschweitzer/dependabot_rules branch from 676ef23 to 65b996a Compare January 17, 2025 11:17
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Jan 17, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 17, 2025

[Fast Unit Tests Report]

On pipeline 53550139 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 17, 2025

Uncompressed package size comparison

Comparison with ancestor 7961fdb1867c6ff10c368b7a4c21ba1ee78b244e

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 929.12MB 929.12MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 938.79MB 938.79MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.79MB 938.79MB 0.50MB
datadog-agent-arm64-deb 0.00MB 915.78MB 915.78MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 925.42MB 925.42MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.93MB 58.93MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.44MB 56.44MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.43MB 477.43MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.99MB 93.99MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 94.06MB 94.06MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 94.06MB 94.06MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 90.04MB 90.04MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.11MB 90.11MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Jan 17, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 952ba086-372d-47d4-9ac8-1b4355cce6c5

Baseline: 7961fdb
Comparison: a4679d9
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_1000ms_latency egress throughput +0.54 [-0.26, +1.35] 1 Logs
quality_gate_idle_all_features memory utilization +0.38 [+0.29, +0.46] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.23 [-0.23, +0.70] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.16 [-0.63, +0.95] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.07, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.70, +0.73] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.93, +0.93] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.98, +0.93] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.92, +0.85] 1 Logs
file_tree memory utilization -0.19 [-0.35, -0.04] 1 Logs
quality_gate_idle memory utilization -0.37 [-0.41, -0.34] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.42 [-3.66, +2.82] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.52 [-1.23, +0.19] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.80 [-0.88, -0.71] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@chouetz chouetz force-pushed the nschweitzer/dependabot_rules branch from 6ebf6aa to a4679d9 Compare January 21, 2025 13:37
@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly and removed medium review PR review might take time labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants