Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FA] Add config version tag in metric #33068

Draft
wants to merge 5 commits into
base: arbll/config-v2
Choose a base branch
from

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Add config_version tag to the datadog.agent.running metric, so Fleet Automation can link policies/configs to what the agent applied

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@coignetp coignetp added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation labels Jan 17, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 17, 2025

Uncompressed package size comparison

Comparison with ancestor 3dda822528f0b314da63e4fd0d387c281089883b

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb -0.02MB 58.83MB 58.85MB 0.50MB
datadog-iot-agent-arm64-deb -0.02MB 89.92MB 89.94MB 0.50MB
datadog-dogstatsd-x86_64-rpm -0.02MB 58.91MB 58.93MB 0.50MB
datadog-dogstatsd-x86_64-suse -0.02MB 58.91MB 58.93MB 0.50MB
datadog-iot-agent-aarch64-rpm -0.02MB 89.99MB 90.01MB 0.50MB
datadog-dogstatsd-arm64-deb -0.02MB 56.34MB 56.36MB 0.50MB
datadog-iot-agent-x86_64-rpm -0.02MB 93.94MB 93.96MB 0.50MB
datadog-iot-agent-x86_64-suse -0.02MB 93.93MB 93.96MB 0.50MB
datadog-iot-agent-amd64-deb -0.02MB 93.87MB 93.89MB 0.50MB
datadog-heroku-agent-amd64-deb -0.04MB 478.12MB 478.16MB 0.50MB
datadog-agent-arm64-deb -0.06MB 915.83MB 915.89MB 0.50MB
datadog-agent-aarch64-rpm -0.06MB 925.47MB 925.53MB 0.50MB
datadog-agent-x86_64-rpm -0.06MB 938.30MB 938.37MB 0.50MB
datadog-agent-x86_64-suse -0.06MB 938.30MB 938.37MB 0.50MB
datadog-agent-amd64-deb -0.07MB 928.64MB 928.71MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 17, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53335913 --os-family=ubuntu

Note: This applies to commit 27030a4

Copy link

cit-pr-commenter bot commented Jan 17, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4f4fb525-0785-4126-a6ec-a1c5832586d0

Baseline: 3dda822
Comparison: 27030a4
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.35 [-1.87, +4.57] 1 Logs
quality_gate_idle memory utilization +0.76 [+0.72, +0.80] 1 Logs bounds checks dashboard
file_tree memory utilization +0.72 [+0.57, +0.86] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.49 [-0.28, +1.26] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.15 [-0.56, +0.86] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.71, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.90, +0.93] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.72, +0.75] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.90, +0.92] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.94, +0.96] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.10] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.08 [-0.55, +0.38] 1 Logs
quality_gate_idle_all_features memory utilization -0.28 [-0.36, -0.20] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.52 [-0.60, -0.45] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/fleet-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants