Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit obfuscation cache cost added and evicted metrics #33083

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lu-zhengda
Copy link
Contributor

What does this PR do?

This PR emits 2 new metrics for the obfuscation cache.

  • datadog.trace_agent.obfuscation.sql_cache.cost_added - measures the sum of costs that have been added (successful Set calls).
  • datadog.trace_agent.obfuscation.sql_cache.cost_evicted - measures the sum of all costs that have been evicted.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-apm trace-agent short review PR is simple enough to be reviewed quickly labels Jan 17, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 7d96bf555f3bfcc870edd123edfd8ffddfc36198

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.00MB 936.90MB 936.90MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 936.90MB 936.90MB 0.50MB
datadog-agent-amd64-deb 0.00MB 927.24MB 927.24MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.87MB 58.87MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.39MB 56.39MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 478.21MB 478.21MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 93.92MB 93.92MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 93.99MB 93.99MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 93.98MB 93.98MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 89.96MB 89.96MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.03MB 90.03MB 0.50MB
datadog-agent-arm64-deb -0.02MB 914.32MB 914.33MB 0.50MB
datadog-agent-aarch64-rpm -0.02MB 923.96MB 923.98MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53376712 --os-family=ubuntu

Note: This applies to commit 91b280e

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 79c6e003-e769-4b6f-95c7-b72d929f42f6

Baseline: 7d96bf5
Comparison: 91b280e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.70 [+0.99, +2.42] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.57 [+0.51, +0.64] 1 Logs
quality_gate_logs % cpu utilization +0.48 [-2.69, +3.66] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.38 [-0.43, +1.19] 1 Logs
quality_gate_idle_all_features memory utilization +0.32 [+0.24, +0.39] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.22 [-0.56, +1.00] 1 Logs
quality_gate_idle memory utilization +0.11 [+0.07, +0.15] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.10 [-0.75, +0.94] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.67, +0.73] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.84, +0.86] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.08, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.06 [-1.01, +0.89] 1 Logs
file_tree memory utilization -0.10 [-0.26, +0.05] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.31 [-0.78, +0.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant