Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS-3833] allow activity dump remote storage to refresh api key at runtime #33085

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Jan 17, 2025

What does this PR do?

This PR allows the activity dump remote storage to fetch the api key at send time and not at creation time. This will allow the secrets/config refresh mechanism to change the api key for this endpoint at runtime and for this remote storage to continue working using the new api key.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added component/system-probe short review PR is simple enough to be reviewed quickly team/agent-security labels Jan 17, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 3c42298e014c85d807a21d4888b3277c465a3270

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 58.95MB 58.95MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.02MB 59.02MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.02MB 59.02MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.46MB 56.46MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 478.37MB 478.37MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 94.01MB 94.01MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 94.08MB 94.08MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 94.08MB 94.08MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 90.05MB 90.05MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.12MB 90.12MB 0.50MB
datadog-agent-arm64-deb -0.01MB 914.54MB 914.56MB 0.50MB
datadog-agent-aarch64-rpm -0.01MB 924.19MB 924.20MB 0.50MB
datadog-agent-amd64-deb -0.02MB 927.45MB 927.46MB 0.50MB
datadog-agent-x86_64-rpm -0.02MB 937.11MB 937.12MB 0.50MB
datadog-agent-x86_64-suse -0.02MB 937.11MB 937.12MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53384447 --os-family=ubuntu

Note: This applies to commit 640cc2c

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8b978d66-ebdf-466b-af2c-e523c2ef2089

Baseline: 3c42298
Comparison: 640cc2c
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_to_blackhole_500ms_latency egress throughput +0.19 [-0.60, +0.98] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.10 [-0.63, +0.83] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.92, +0.93] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.00 [-0.84, +0.84] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.64, +0.63] 1 Logs
quality_gate_idle memory utilization -0.03 [-0.07, +0.00] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.92, +0.83] 1 Logs
quality_gate_idle_all_features memory utilization -0.05 [-0.14, +0.03] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.06 [-0.86, +0.74] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.14 [-0.61, +0.32] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.36 [-1.07, +0.36] 1 Logs
file_tree memory utilization -0.50 [-0.63, -0.36] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.27 [-1.32, -1.21] 1 Logs
quality_gate_logs % cpu utilization -2.75 [-5.90, +0.40] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jan 18, 2025
@paulcacheux paulcacheux marked this pull request as ready for review January 18, 2025 09:28
@paulcacheux paulcacheux requested a review from a team as a code owner January 18, 2025 09:28
@paulcacheux paulcacheux changed the title [CWS] allow activity dump remote storage to refresh api key at runtime [CWS-3833] allow activity dump remote storage to refresh api key at runtime Jan 19, 2025
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 20, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-20 08:11:10 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-20 08:50:28 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 9e497a7 into main Jan 20, 2025
256 of 258 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/api-key-refresh-activity-dumps branch January 20, 2025 08:50
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants