Skip to content

Setup CWS Quality Gates#50373

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
paul.reinlein/cws-quality-gates
May 6, 2026
Merged

Setup CWS Quality Gates#50373
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
paul.reinlein/cws-quality-gates

Conversation

@preinlein
Copy link
Copy Markdown
Contributor

@preinlein preinlein commented May 5, 2026

What does this PR do?

Adds three SMP regression quality gates for CWS (Workload Protection) under test/regression/cases/:

  • quality_gate_security_idle — CWS on, shipped default policy, no lading generator. Baseline "turn it on and leave it alone" floor.
  • quality_gate_security_no_fs_load — CWS on, experiment-supplied default.policy, no generator. Isolates policy + approver overhead at zero application load.
  • quality_gate_security_mean_fs_load — CWS on, same experiment default.policy, file_tree generator sized to org2's per-host mean perf_buffer.events.write rate.

Each cases enforces a memory & cpu bound.

Removes the file_tree experiment:

  • It was not a quality gate
  • It had no bounds checks
  • It lacked a readme
  • It somewhat tests similar functionality as these quality gates
  • It wasn't really maintained (all updates are from SMP and not really related to what's being tested)

Motivation

CWS lacks quality-gate coverage in SMP. The three gates form a ladder — idle → no-load-with-policy → mean-FS-load — so a memory regression can be attributed to policy loading, approver overhead, or event-processing overhead rather than lumped together. The mean-FS-load rate (open_per_second: 41) reflects the org2 per-host weekly mean for perf_buffer.events.write so the gate tracks production rather than an arbitrary stressor.

Describe how you validated your changes

  • Ran the three experiments via SMP and iterated on agent config & bounds
  • Many tests of the quality gates using this notebook to verify what I'm seeing.

The majority of the work involved understanding how things work: what the CWS SLOs are, what they measure, what that is/means in production, configuring the agent to properly exercise the load we're putting on it, etc.

Additional Notes

  • file_tree max_nodes: 500000 is sized to exceed open_per_second × run_duration so the tree never exhausts mid-capture (once all nodes exist, subsequent opens are O_RDONLY and rejected by CWS flag approvers).
  • activity_dump.enabled: false in both security-agent.yaml and system-probe.yaml — activity dump is being reworked and adds unpredictable kernel-event volume.

Copy link
Copy Markdown
Contributor Author

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/agent-security labels May 5, 2026
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label May 5, 2026
@preinlein preinlein added the changelog/no-changelog No changelog entry needed label May 5, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

Files inventory check summary

File checks results against ancestor 8f67edd8:

Results for datadog-agent_7.80.0~devel.git.484.c0afd84.pipeline.111519545-1_amd64.deb:

No change detected

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 8f67edd
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 740.964 → 750.310
agent_deb_amd64_fips N/A N/A → 699.148 → 702.690
agent_heroku_amd64 N/A N/A → 309.076 → 313.960
agent_rpm_amd64 N/A N/A → 740.948 → 750.280
agent_rpm_amd64_fips N/A N/A → 699.132 → 702.670
agent_rpm_arm64 N/A N/A → 719.022 → 724.050
agent_rpm_arm64_fips N/A N/A → 680.301 → 684.460
agent_suse_amd64 N/A N/A → 740.948 → 750.280
agent_suse_amd64_fips N/A N/A → 699.132 → 702.670
agent_suse_arm64 N/A N/A → 719.022 → 724.050
agent_suse_arm64_fips N/A N/A → 680.301 → 684.460
docker_agent_amd64 N/A N/A → 801.344 → 805.870
docker_agent_arm64 N/A N/A → 804.246 → 809.730
docker_agent_jmx_amd64 N/A N/A → 992.263 → 996.590
docker_agent_jmx_arm64 N/A N/A → 983.944 → 989.410
docker_cluster_agent_amd64 N/A N/A → 206.603 → 207.600
docker_cluster_agent_arm64 N/A N/A → 220.634 → 221.150
docker_cws_instrumentation_amd64 N/A N/A → 7.142 → 7.180
docker_cws_instrumentation_arm64 N/A N/A → 6.689 → 6.920
docker_host_profiler_amd64 N/A N/A → 301.101 → 315.800
docker_host_profiler_arm64 N/A N/A → 312.622 → 327.400
docker_dogstatsd_amd64 N/A N/A → 39.374 → 39.540
docker_dogstatsd_arm64 N/A N/A → 37.628 → 38.080
dogstatsd_deb_amd64 N/A N/A → 30.032 → 30.770
dogstatsd_deb_arm64 N/A N/A → 28.173 → 29.270
dogstatsd_rpm_amd64 N/A N/A → 30.032 → 30.770
dogstatsd_suse_amd64 N/A N/A → 30.032 → 30.770
iot_agent_deb_amd64 N/A N/A → 44.462 → 44.970
iot_agent_deb_arm64 N/A N/A → 41.439 → 42.560
iot_agent_deb_armhf N/A N/A → 42.179 → 42.740
iot_agent_rpm_amd64 N/A N/A → 44.462 → 44.970
iot_agent_suse_amd64 N/A N/A → 44.462 → 44.970
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 175.288 → 179.160
agent_deb_amd64_fips N/A N/A → 167.049 → 174.440
agent_heroku_amd64 N/A N/A → 74.958 → 80.310
agent_rpm_amd64 N/A N/A → 177.308 → 182.080
agent_rpm_amd64_fips N/A N/A → 168.405 → 174.140
agent_rpm_arm64 N/A N/A → 159.404 → 163.610
agent_rpm_arm64_fips N/A N/A → 151.724 → 156.850
agent_suse_amd64 N/A N/A → 177.308 → 182.080
agent_suse_amd64_fips N/A N/A → 168.405 → 174.140
agent_suse_arm64 N/A N/A → 159.404 → 163.610
agent_suse_arm64_fips N/A N/A → 151.724 → 156.850
docker_agent_amd64 N/A N/A → 267.708 → 272.990
docker_agent_arm64 N/A N/A → 254.716 → 261.470
docker_agent_jmx_amd64 N/A N/A → 336.346 → 341.610
docker_agent_jmx_arm64 N/A N/A → 319.363 → 326.050
docker_cluster_agent_amd64 N/A N/A → 72.424 → 73.460
docker_cluster_agent_arm64 N/A N/A → 67.884 → 68.680
docker_cws_instrumentation_amd64 N/A N/A → 2.999 → 3.330
docker_cws_instrumentation_arm64 N/A N/A → 2.729 → 3.090
docker_host_profiler_amd64 N/A N/A → 110.740 → 125.600
docker_host_profiler_arm64 N/A N/A → 105.089 → 120.000
docker_dogstatsd_amd64 N/A N/A → 15.240 → 15.870
docker_dogstatsd_arm64 N/A N/A → 14.558 → 14.890
dogstatsd_deb_amd64 N/A N/A → 7.943 → 8.830
dogstatsd_deb_arm64 N/A N/A → 6.826 → 7.750
dogstatsd_rpm_amd64 N/A N/A → 7.952 → 8.840
dogstatsd_suse_amd64 N/A N/A → 7.952 → 8.840
iot_agent_deb_amd64 N/A N/A → 11.700 → 13.210
iot_agent_deb_arm64 N/A N/A → 9.995 → 11.620
iot_agent_deb_armhf N/A N/A → 10.209 → 11.780
iot_agent_rpm_amd64 N/A N/A → 11.720 → 13.230
iot_agent_suse_amd64 N/A N/A → 11.720 → 13.230

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 5, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 8eb9982f-6bf3-44e2-bf8b-81d8db1eb80f

Baseline: 6416cce
Comparison: 6e077b5
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.54 [+0.57, +6.51] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.54 [+0.57, +6.51] 1 Logs
quality_gate_logs % cpu utilization +0.93 [-0.06, +1.92] 1 Logs bounds checks dashboard
otlp_ingest_logs memory utilization +0.80 [+0.69, +0.91] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.54 [+0.38, +0.69] 1 Logs
ddot_metrics memory utilization +0.39 [+0.19, +0.58] 1 Logs
ddot_metrics_sum_delta memory utilization +0.33 [+0.16, +0.51] 1 Logs
quality_gate_idle_all_features memory utilization +0.24 [+0.19, +0.28] 1 Logs bounds checks dashboard
quality_gate_security_mean_fs_load memory utilization +0.18 [+0.14, +0.22] 1 Logs bounds checks dashboard
quality_gate_security_idle memory utilization +0.14 [+0.07, +0.22] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.10 [+0.00, +0.21] 1 Logs
otlp_ingest_metrics memory utilization +0.10 [-0.06, +0.26] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.04 [-0.17, +0.25] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.03 [-0.41, +0.47] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.21] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.10, +0.11] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.54, +0.53] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.20, +0.20] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.42, +0.39] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.20, +0.09] 1 Logs
quality_gate_security_no_fs_load memory utilization -0.10 [-0.21, -0.00] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.16 [-0.21, -0.12] 1 Logs
quality_gate_idle memory utilization -0.26 [-0.31, -0.21] 1 Logs bounds checks dashboard
ddot_logs memory utilization -0.29 [-0.37, -0.21] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.46 [-0.69, -0.22] 1 Logs
quality_gate_metrics_logs memory utilization -0.50 [-0.75, -0.25] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 694 ≥ 26
docker_containers_memory memory_usage 10/10 245.35MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 700 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 141.12MiB ≤ 147MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 466.82MiB ≤ 495MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 175.80MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 336.11 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 380.27MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 26.12 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 291.89MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 52.35 ≤ 70 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 266.30MiB ≤ 320MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 22.25 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 269.67MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@preinlein preinlein force-pushed the paul.reinlein/cws-quality-gates branch from ed82d28 to 3e76efa Compare May 5, 2026 15:05
@preinlein preinlein added the qa/no-code-change No code change in Agent code requiring validation label May 5, 2026
@preinlein preinlein force-pushed the paul.reinlein/cws-quality-gates branch from 3e76efa to c0afd84 Compare May 5, 2026 15:12
@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented May 5, 2026

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 50.28% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c0afd84 | Docs | Datadog PR Page | Give us feedback!

@preinlein preinlein marked this pull request as ready for review May 5, 2026 17:54
@preinlein preinlein requested a review from a team as a code owner May 5, 2026 17:54
@preinlein preinlein mentioned this pull request May 5, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0afd844a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +9 to +10
remote_configuration:
enabled: false
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Nest remote configuration setting under runtime_security_config

remote_configuration.enabled is currently set at the top level of system-probe.yaml, but CWS remote-config gating is read from runtime_security_config.remote_configuration.enabled (and then combined with global remote_configuration.enabled) in pkg/security/config/config.go (isRemoteConfigEnabled, lines 735-748). With this placement, the CWS-specific flag stays at its default true, so these quality gates still run with RC enabled, which can introduce remote policy/config traffic and non-deterministic overhead instead of the intended local-policy-only baseline. The same pattern appears in the other two new security quality-gate cases as well.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes against the guidance I was provided by CWS. We can investigate later - non blocker.

@preinlein
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 5, 2026

View all feedbacks in Devflow UI.

2026-05-05 19:47:57 UTC ℹ️ Start processing command /merge


2026-05-05 19:48:04 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-05-05 23:54:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@preinlein preinlein requested a review from a team May 5, 2026 19:49
@preinlein
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 6, 2026

View all feedbacks in Devflow UI.

2026-05-06 12:40:55 UTC ℹ️ Start processing command /merge


2026-05-06 12:41:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-05-06 14:18:31 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 6e077b5 into main May 6, 2026
236 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the paul.reinlein/cws-quality-gates branch May 6, 2026 14:18
@github-actions github-actions Bot added this to the 7.80.0 milestone May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants