Skip to content

[observer] Isolate reporter#50377

Open
CelianR wants to merge 11 commits intoq-branch-observerfrom
celian/reporter
Open

[observer] Isolate reporter#50377
CelianR wants to merge 11 commits intoq-branch-observerfrom
celian/reporter

Conversation

@CelianR
Copy link
Copy Markdown
Contributor

@CelianR CelianR commented May 5, 2026

What does this PR do?

This isolates the reporter component.

  • Removed HTML reporter (useless)
  • ℹ️ The testbench code will move when we will isolate the testbench code

Extra changes

  • Restore rate annotations in live events: When the reporter was isolated, EventReporter lost access to eng.Storage() (needed to compute log rate changes in event messages). Fixed via a new StorageConsumer interface in reporter/def — the observer calls SetStorage(eng.Storage()) on any reporter that implements it during wiring. No circular Fx dependency.
  • Updated allium: Corrected NonBlocking invariant (send is synchronous, not goroutine-delegated) and updated RateAnnotations invariant to reflect the StorageConsumer pattern.
  • Moved constants: Moves constants to constants.go.

Motivation

Describe how you validated your changes

Additional Notes

@CelianR CelianR self-assigned this May 5, 2026
@CelianR CelianR force-pushed the celian/reporter branch from 31537e3 to 8158557 Compare May 5, 2026 14:13
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

Gitlab CI Configuration Changes

Updated: .gitlab-ci.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
5 467 24 0

Updated: .gitlab/childs/smp-regression-child-pipeline.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 3 3 0

Updated: .gitlab/distribution.yml

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
2 2 7 0

ℹ️ Diff available in the job log.

// Copyright 2016-present Datadog, Inc.

package observerimpl
package reporterimpl
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will move when we will refactor the testbench

@CelianR CelianR changed the title [observer] Reporter [observer] Isolate reporter May 5, 2026
@github-actions github-actions Bot added the long review PR is complex, plan time to review it label May 5, 2026
@CelianR CelianR force-pushed the celian/reporter branch from b518608 to fc1d834 Compare May 5, 2026 15:38
@datadog-prod-us1-5
Copy link
Copy Markdown
Contributor

datadog-prod-us1-5 Bot commented May 5, 2026

🎯 Code Coverage (details)
Patch Coverage: 11.11%
Overall Coverage: 50.37% (-0.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 28d1889 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor e5b320d
📊 Static Quality Gates Dashboard
🔗 SQG Job
SOME SIZE DELTAS ARE N/A (ANCESTOR METRICS NOT YET AVAILABLE). RETRY JOB

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 741.887 → 750.310
agent_deb_amd64_fips N/A N/A → 700.059 → 702.690
agent_heroku_amd64 N/A N/A → 309.908 → 313.960
agent_msi N/A N/A → 609.001 → 623.540
agent_rpm_amd64 N/A N/A → 741.870 → 750.280
agent_rpm_amd64_fips N/A N/A → 700.043 → 702.670
agent_rpm_arm64 N/A N/A → 719.925 → 724.050
agent_rpm_arm64_fips N/A N/A → 681.134 → 684.460
agent_suse_amd64 N/A N/A → 741.870 → 750.280
agent_suse_amd64_fips N/A N/A → 700.043 → 702.670
agent_suse_arm64 N/A N/A → 719.925 → 724.050
agent_suse_arm64_fips N/A N/A → 681.134 → 684.460
docker_agent_amd64 N/A N/A → 802.241 → 805.870
docker_agent_arm64 N/A N/A → 805.085 → 809.730
docker_agent_jmx_amd64 N/A N/A → 993.161 → 996.590
docker_agent_jmx_arm64 N/A N/A → 984.784 → 989.410
docker_cluster_agent_amd64 N/A N/A → 206.611 → 207.600
docker_cluster_agent_arm64 N/A N/A → 220.635 → 221.150
docker_cws_instrumentation_amd64 N/A N/A → 7.142 → 7.180
docker_cws_instrumentation_arm64 N/A N/A → 6.689 → 6.920
docker_host_profiler_amd64 N/A N/A → 301.149 → 315.800
docker_host_profiler_arm64 N/A N/A → 312.696 → 327.400
docker_dogstatsd_amd64 N/A N/A → 39.398 → 39.540
docker_dogstatsd_arm64 N/A N/A → 37.628 → 38.080
dogstatsd_deb_amd64 N/A N/A → 30.052 → 30.770
dogstatsd_deb_arm64 N/A N/A → 28.193 → 29.270
dogstatsd_rpm_amd64 N/A N/A → 30.052 → 30.770
dogstatsd_suse_amd64 N/A N/A → 30.052 → 30.770
iot_agent_deb_amd64 N/A N/A → 44.486 → 44.970
iot_agent_deb_arm64 N/A N/A → 41.466 → 42.560
iot_agent_deb_armhf N/A N/A → 42.206 → 42.740
iot_agent_rpm_amd64 N/A N/A → 44.486 → 44.970
iot_agent_suse_amd64 N/A N/A → 44.486 → 44.970
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 N/A N/A → 175.579 → 179.160
agent_deb_amd64_fips N/A N/A → 167.289 → 174.440
agent_heroku_amd64 N/A N/A → 75.146 → 80.310
agent_msi N/A N/A → 140.910 → 148.730
agent_rpm_amd64 N/A N/A → 177.574 → 182.080
agent_rpm_amd64_fips N/A N/A → 168.580 → 174.140
agent_rpm_arm64 N/A N/A → 159.655 → 163.610
agent_rpm_arm64_fips N/A N/A → 151.943 → 156.850
agent_suse_amd64 N/A N/A → 177.574 → 182.080
agent_suse_amd64_fips N/A N/A → 168.580 → 174.140
agent_suse_arm64 N/A N/A → 159.655 → 163.610
agent_suse_arm64_fips N/A N/A → 151.943 → 156.850
docker_agent_amd64 N/A N/A → 267.994 → 272.990
docker_agent_arm64 N/A N/A → 255.004 → 261.470
docker_agent_jmx_amd64 N/A N/A → 336.658 → 341.610
docker_agent_jmx_arm64 N/A N/A → 319.661 → 326.050
docker_cluster_agent_amd64 N/A N/A → 72.418 → 73.460
docker_cluster_agent_arm64 N/A N/A → 67.868 → 68.680
docker_cws_instrumentation_amd64 N/A N/A → 2.999 → 3.330
docker_cws_instrumentation_arm64 N/A N/A → 2.729 → 3.090
docker_host_profiler_amd64 N/A N/A → 110.758 → 125.600
docker_host_profiler_arm64 N/A N/A → 105.093 → 120.000
docker_dogstatsd_amd64 N/A N/A → 15.247 → 15.870
docker_dogstatsd_arm64 N/A N/A → 14.560 → 14.890
dogstatsd_deb_amd64 N/A N/A → 7.948 → 8.830
dogstatsd_deb_arm64 N/A N/A → 6.830 → 7.750
dogstatsd_rpm_amd64 N/A N/A → 7.958 → 8.840
dogstatsd_suse_amd64 N/A N/A → 7.958 → 8.840
iot_agent_deb_amd64 N/A N/A → 11.706 → 13.210
iot_agent_deb_arm64 N/A N/A → 10.004 → 11.620
iot_agent_deb_armhf N/A N/A → 10.210 → 11.780
iot_agent_rpm_amd64 N/A N/A → 11.723 → 13.230
iot_agent_suse_amd64 N/A N/A → 11.723 → 13.230

Base automatically changed from q-branch-observer-clean to q-branch-observer May 6, 2026 12:13
@CelianR CelianR force-pushed the celian/reporter branch from 4a870ea to efbcc5e Compare May 6, 2026 12:22
@CelianR CelianR force-pushed the celian/reporter branch from efbcc5e to 769025c Compare May 6, 2026 13:41
@CelianR CelianR marked this pull request as ready for review May 6, 2026 13:52
@CelianR CelianR requested review from a team as code owners May 6, 2026 13:52
@CelianR CelianR requested review from Enzu83 and misteriaud May 6, 2026 13:52
@CelianR CelianR requested a review from a team as a code owner May 6, 2026 15:25
@CelianR
Copy link
Copy Markdown
Contributor Author

CelianR commented May 6, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

long review PR is complex, plan time to review it no-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant