[observer] Isolate reporter#50377
Conversation
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 5 | 467 | 24 | 0 |
Updated: .gitlab/childs/smp-regression-child-pipeline.yml
Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 3 | 3 | 0 |
Updated: .gitlab/distribution.yml
Changes Summary
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 2 | 2 | 7 | 0 |
ℹ️ Diff available in the job log.
| // Copyright 2016-present Datadog, Inc. | ||
|
|
||
| package observerimpl | ||
| package reporterimpl |
There was a problem hiding this comment.
This will move when we will refactor the testbench
|
🎯 Code Coverage (details) 🔗 Commit SHA: 28d1889 | Docs | Datadog PR Page | Give us feedback! |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
On-wire sizes (compressed)
|
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
What does this PR do?
This isolates the reporter component.
Extra changes
EventReporterlost access toeng.Storage()(needed to compute log rate changes in event messages). Fixed via a newStorageConsumerinterface inreporter/def— the observer callsSetStorage(eng.Storage())on any reporter that implements it during wiring. No circular Fx dependency.NonBlockinginvariant (send is synchronous, not goroutine-delegated) and updatedRateAnnotationsinvariant to reflect theStorageConsumerpattern.constants.go.Motivation
Describe how you validated your changes
Additional Notes