[#incident-53970] Use staging replication for branch agent images#50378
Conversation
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 8 | 0 | 0 |
ℹ️ Diff available in the job log.
This comment has been minimized.
This comment has been minimized.
Files inventory check summaryFile checks results against ancestor e1881833: Results for datadog-agent_7.80.0~devel.git.498.5869e86.pipeline.111585185-1_amd64.deb:No change detected |
f994d1f to
a13be13
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status waiting |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
/merge -p incident |
|
View all feedbacks in Devflow UI.
PR already in the queue with status in_progress |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 3bdc22e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.15 | [-1.79, +4.10] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +1.15 | [-1.79, +4.10] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.45 | [+0.20, +0.70] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_metrics | memory utilization | +0.41 | [+0.25, +0.57] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.28 | [+0.05, +0.52] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.20 | [+0.15, +0.25] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.15 | [-0.04, +0.34] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.11 | [-0.39, +0.61] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.06 | [-0.13, +0.26] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.06 | [-0.34, +0.46] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.04 | [-0.00, +0.08] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.10, +0.09] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.02 | [-0.21, +0.18] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.02 | [-0.07, +0.03] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.49, +0.38] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.19, +0.08] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.06 | [-0.16, +0.03] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.07 | [-0.12, -0.02] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | -0.09 | [-0.19, +0.01] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.14 | [-1.12, +0.84] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | -0.24 | [-0.29, -0.18] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.34 | [-0.51, -0.17] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.46 | [-0.62, -0.30] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 731 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 245.23MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 698 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 142.22MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 468.59MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 175.29MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 354.46 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 392.03MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
…50409) ## Summary - Stop pinning non-tag internal image builds to `DataDog/images@datadog-agent-staging-replication`. - Keep the trigger on `DataDog/images@master` and rely on DataDog/images#9692 to make `RELEASE_STAGING=true` produce staging-target images from master. - Set `RELEASE_STAGING=true` only for non-tag pipelines so tag/prod paths are not unintentionally downgraded to staging by the new images behavior. ## Context - Builds on the workaround merged in #50378. - Depends on DataDog/images#9692. ## Validation - [x] Make sure dev builds from branches have the target: staging annotation - [ ] Make sure rcs have target:prod Co-authored-by: ali.benabdallah <ali.benabdallah@datadoghq.com>
Summary
DataDog/images@master.DataDog/images@datadog-agent-staging-replication.RELEASE_PRODin the non-tag path so branch/custom image pipelines only create staging release tags.Notes
RELEASE_PROD/RELEASE_STAGINGdo not set replication annotations directly; they select release and publish jobs in the images pipeline.Validation
git diff --check.gitlab/deploy/internal_image_deploy/internal_image_deploy.ymlorigin/main; the clean branch push used--no-verifyafter the hook push stalled.