Skip to content

chore(test): add apm-inject e2e test with reboot#50383

Draft
maattdd wants to merge 1 commit intomainfrom
maattdd/apm-inject-e2e-test-reboot
Draft

chore(test): add apm-inject e2e test with reboot#50383
maattdd wants to merge 1 commit intomainfrom
maattdd/apm-inject-e2e-test-reboot

Conversation

@maattdd
Copy link
Copy Markdown
Contributor

@maattdd maattdd commented May 5, 2026

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

@dd-octo-sts dd-octo-sts Bot added internal Identify a non-fork PR team/windows-products labels May 5, 2026
@github-actions github-actions Bot added the medium review PR review might take time label May 5, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

Files inventory check summary

File checks results against ancestor d4c2baff:

Results for datadog-agent_7.80.0~devel.git.564.1f72e76.pipeline.111960747-1_amd64.deb:

No change detected

@maattdd maattdd force-pushed the maattdd/apm-inject-e2e-test-reboot branch 3 times, most recently from 0436be1 to 71186e7 Compare May 6, 2026 15:57
@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 6, 2026

🎯 Code Coverage (details)
Patch Coverage: 90.00%
Overall Coverage: 50.14% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1f72e76 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 6, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor d4c2baf
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

Quality gate Change Size (prev → curr → max)
agent_deb_amd64_fips +3.56 KiB (0.00% increase) 700.625 → 700.628 → 702.690
agent_rpm_amd64_fips +3.56 KiB (0.00% increase) 700.609 → 700.612 → 702.670
agent_suse_amd64_fips +3.56 KiB (0.00% increase) 700.609 → 700.612 → 702.670
29 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 742.593 MiB
agent_heroku_amd64 309.245 MiB
agent_rpm_amd64 742.577 MiB
agent_rpm_arm64 720.489 MiB
agent_rpm_arm64_fips 681.600 MiB
agent_suse_amd64 742.577 MiB
agent_suse_arm64 720.489 MiB
agent_suse_arm64_fips 681.600 MiB
docker_agent_amd64 802.781 MiB
docker_agent_arm64 805.526 MiB
docker_agent_jmx_amd64 993.701 MiB
docker_agent_jmx_arm64 985.225 MiB
docker_cluster_agent_amd64 206.658 MiB
docker_cluster_agent_arm64 220.697 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_host_profiler_amd64 301.638 MiB
docker_host_profiler_arm64 313.129 MiB
docker_dogstatsd_amd64 39.507 MiB
docker_dogstatsd_arm64 37.753 MiB
dogstatsd_deb_amd64 30.161 MiB
dogstatsd_deb_arm64 28.290 MiB
dogstatsd_rpm_amd64 30.161 MiB
dogstatsd_suse_amd64 30.161 MiB
iot_agent_deb_amd64 44.517 MiB
iot_agent_deb_arm64 41.494 MiB
iot_agent_deb_armhf 42.230 MiB
iot_agent_rpm_amd64 44.518 MiB
iot_agent_suse_amd64 44.518 MiB

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 6, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e8a74cd7-8084-48a0-9c41-ad1ac76552cb

Baseline: d4c2baf
Comparison: 1f72e76
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +0.16 [-2.80, +3.11] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs memory utilization +1.12 [+1.02, +1.23] 1 Logs
otlp_ingest_metrics memory utilization +0.96 [+0.81, +1.12] 1 Logs
quality_gate_idle_all_features memory utilization +0.44 [+0.40, +0.48] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.17 [+0.12, +0.22] 1 Logs
docker_containers_cpu % cpu utilization +0.16 [-2.80, +3.11] 1 Logs
docker_containers_memory memory utilization +0.15 [+0.05, +0.26] 1 Logs
quality_gate_security_idle memory utilization +0.11 [+0.03, +0.18] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.46, +0.56] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.36, +0.44] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.13, +0.16] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.21] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.09, +0.10] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.21, +0.21] 1 Logs
ddot_logs memory utilization -0.02 [-0.08, +0.05] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.47, +0.42] 1 Logs
quality_gate_security_mean_fs_load memory utilization -0.03 [-0.07, +0.01] 1 Logs bounds checks dashboard
quality_gate_security_no_fs_load memory utilization -0.03 [-0.14, +0.07] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization -0.05 [-0.31, +0.20] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.11 [-0.30, +0.08] 1 Logs
quality_gate_idle memory utilization -0.30 [-0.35, -0.25] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization -0.37 [-0.57, -0.17] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.43 [-0.66, -0.20] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.66 [-0.82, -0.50] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.03 [-1.27, -0.79] 1 Logs
quality_gate_logs % cpu utilization -4.32 [-5.30, -3.33] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 704 ≥ 26
docker_containers_memory memory_usage 10/10 246.32MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 695 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.16GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.17GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.18GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 141.60MiB ≤ 147MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 ≤ 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 467.03MiB ≤ 495MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 177.10MiB ≤ 195MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 368.17 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 380.60MiB ≤ 430MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_security_idle cpu_usage 10/10 21.59 ≤ 40 bounds checks dashboard
quality_gate_security_idle memory_usage 10/10 287.21MiB ≤ 330MiB bounds checks dashboard
quality_gate_security_mean_fs_load cpu_usage 10/10 52.52 ≤ 70 bounds checks dashboard
quality_gate_security_mean_fs_load memory_usage 10/10 268.26MiB ≤ 320MiB bounds checks dashboard
quality_gate_security_no_fs_load cpu_usage 10/10 20.46 ≤ 40 bounds checks dashboard
quality_gate_security_no_fs_load memory_usage 10/10 278.26MiB ≤ 320MiB bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

@maattdd maattdd force-pushed the maattdd/apm-inject-e2e-test-reboot branch from d5532c4 to 1f72e76 Compare May 7, 2026 11:14
@maattdd maattdd added changelog/no-changelog No changelog entry needed qa/done QA done before merge and regressions are covered by tests labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/windows-products

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant