`bazel`ify proto generation: `languagedetection` leftover by rdesgroppes · Pull Request #50394 · DataDog/datadog-agent

rdesgroppes · 2026-05-05T16:40:36Z

What does this PR do?

Move languagedetection out of PROTO_PKGS in tasks/protobuf.py, delegating .pb.go generation to the topmost bazel command: bazel run //pkg/proto/pbgo/languagedetection:write_pb_go.

Motivation

Complete the languagedetection bazelification started in #49918, which missed the corresponding tasks/protobuf.py change - sorry for that!

Describe how you validated your changes

dda inv protobuf.generate succeeds.

Additional Notes

bazel run //pkg/proto/pbgo/languagedetection:write_pb_go is merely left for didactic purposes so that colleagues get to know how such in-workspace files can be (re)generated.

### What does this PR do? Move `languagedetection` out of `PROTO_PKGS` in `tasks/protobuf.py`, delegating `.pb.go` generation to the topmost `bazel` command: `bazel run //pkg/proto/pbgo/languagedetection:write_pb_go`. ### Motivation Complete the `languagedetection` `bazel`ification started in #49918, which missed the corresponding `tasks/protobuf.py` change. ### Describe how you validated your changes `dda inv protobuf.generate` succeeds. ### Additional Notes `bazel run //pkg/proto/pbgo/languagedetection:write_pb_go` is merely left for didactic purposes so that colleagues get to know how in-workspace file is (re)generated.

datadog-official · 2026-05-05T16:58:54Z

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 50.27% (-0.01%)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 03471d7 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-05-05T17:06:19Z

Files inventory check summary

File checks results against ancestor 60cf70f7:

Results for datadog-agent_7.80.0~devel.git.492.03471d7.pipeline.111545547-1_amd64.deb:

No change detected

dd-octo-sts · 2026-05-05T17:16:26Z

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 60cf70f
📊 Static Quality Gates Dashboard
🔗 SQG Job

32 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	741.298 MiB
✅	agent_deb_amd64_fips	699.364 MiB
✅	agent_heroku_amd64	309.139 MiB
✅	agent_rpm_amd64	741.282 MiB
✅	agent_rpm_amd64_fips	699.348 MiB
✅	agent_rpm_arm64	719.321 MiB
✅	agent_rpm_arm64_fips	680.494 MiB
✅	agent_suse_amd64	741.282 MiB
✅	agent_suse_amd64_fips	699.348 MiB
✅	agent_suse_arm64	719.321 MiB
✅	agent_suse_arm64_fips	680.494 MiB
✅	docker_agent_amd64	801.540 MiB
✅	docker_agent_arm64	804.420 MiB
✅	docker_agent_jmx_amd64	992.460 MiB
✅	docker_agent_jmx_arm64	984.119 MiB
✅	docker_cluster_agent_amd64	206.607 MiB
✅	docker_cluster_agent_arm64	220.634 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_host_profiler_amd64	301.102 MiB
✅	docker_host_profiler_arm64	312.623 MiB
✅	docker_dogstatsd_amd64	39.492 MiB
✅	docker_dogstatsd_arm64	37.690 MiB
✅	dogstatsd_deb_amd64	30.145 MiB
✅	dogstatsd_deb_arm64	28.275 MiB
✅	dogstatsd_rpm_amd64	30.145 MiB
✅	dogstatsd_suse_amd64	30.145 MiB
✅	iot_agent_deb_amd64	44.462 MiB
✅	iot_agent_deb_arm64	41.442 MiB
✅	iot_agent_deb_armhf	42.179 MiB
✅	iot_agent_rpm_amd64	44.462 MiB
✅	iot_agent_suse_amd64	44.462 MiB

On-wire sizes (compressed)

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64	-3.26 KiB (0.00% reduction)	175.373 → 175.370 → 179.160
✅	agent_deb_amd64_fips	-44.35 KiB (0.03% reduction)	167.093 → 167.050 → 174.440
✅	agent_heroku_amd64	-4.15 KiB (0.01% reduction)	74.985 → 74.980 → 80.310
✅	agent_rpm_amd64	+40.1 KiB (0.02% increase)	177.373 → 177.412 → 182.080
✅	agent_rpm_amd64_fips	-10.41 KiB (0.01% reduction)	168.468 → 168.458 → 174.140
✅	agent_rpm_arm64	+2.45 KiB (0.00% increase)	159.449 → 159.452 → 163.610
✅	agent_rpm_arm64_fips	+39.82 KiB (0.03% increase)	151.739 → 151.778 → 156.850
✅	agent_suse_amd64	+40.1 KiB (0.02% increase)	177.373 → 177.412 → 182.080
✅	agent_suse_amd64_fips	-10.41 KiB (0.01% reduction)	168.468 → 168.458 → 174.140
✅	agent_suse_arm64	+2.45 KiB (0.00% increase)	159.449 → 159.452 → 163.610
✅	agent_suse_arm64_fips	+39.82 KiB (0.03% increase)	151.739 → 151.778 → 156.850
✅	docker_agent_amd64	neutral	267.780 MiB → 272.990
✅	docker_agent_arm64	neutral	254.799 MiB → 261.470
✅	docker_agent_jmx_amd64	neutral	336.418 MiB → 341.610
✅	docker_agent_jmx_arm64	neutral	319.440 MiB → 326.050
✅	docker_cluster_agent_amd64	neutral	72.423 MiB → 73.460
✅	docker_cluster_agent_arm64	neutral	67.874 MiB → 68.680
✅	docker_cws_instrumentation_amd64	neutral	2.999 MiB → 3.330
✅	docker_cws_instrumentation_arm64	neutral	2.729 MiB → 3.090
✅	docker_host_profiler_amd64	neutral	110.737 MiB → 125.600
✅	docker_host_profiler_arm64	neutral	105.081 MiB → 120.000
✅	docker_dogstatsd_amd64	neutral	15.286 MiB → 15.870
✅	docker_dogstatsd_arm64	neutral	14.597 MiB → 14.890
✅	dogstatsd_deb_amd64	neutral	7.976 MiB → 8.830
✅	dogstatsd_deb_arm64	neutral	6.856 MiB → 7.750
✅	dogstatsd_rpm_amd64	neutral	7.986 MiB → 8.840
✅	dogstatsd_suse_amd64	neutral	7.986 MiB → 8.840
✅	iot_agent_deb_amd64	neutral	11.703 MiB → 13.210
✅	iot_agent_deb_arm64	+3.45 KiB (0.03% increase)	9.999 → 10.002 → 11.620
✅	iot_agent_deb_armhf	neutral	10.212 MiB → 11.780
✅	iot_agent_rpm_amd64	neutral	11.715 MiB → 13.230
✅	iot_agent_suse_amd64	neutral	11.715 MiB → 13.230

cit-pr-commenter-54b7da · 2026-05-05T17:27:35Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 239c4da9-ced9-45fa-a134-93523d7952d7

Baseline: 6e077b5
Comparison: f7a74eb
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+4.39	[+1.38, +7.40]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+4.39	[+1.38, +7.40]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.81	[-0.18, +1.79]	1	Logs bounds checks dashboard
➖	ddot_metrics	memory utilization	+0.47	[+0.28, +0.66]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	+0.30	[+0.25, +0.35]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.10	[-0.34, +0.54]	1	Logs
➖	ddot_logs	memory utilization	+0.03	[-0.04, +0.09]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.01	[-0.09, +0.11]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.00	[-0.18, +0.19]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.15, +0.14]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.20, +0.18]	1	Logs
➖	quality_gate_idle	memory utilization	-0.03	[-0.08, +0.01]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_v3	ingress throughput	-0.04	[-0.26, +0.18]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.04	[-0.44, +0.36]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.08	[-0.57, +0.40]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.09	[-0.25, +0.08]	1	Logs
➖	quality_gate_security_idle	memory utilization	-0.13	[-0.20, -0.06]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.14	[-0.17, -0.10]	1	Logs bounds checks dashboard
➖	docker_containers_memory	memory utilization	-0.25	[-0.35, -0.15]	1	Logs
➖	otlp_ingest_logs	memory utilization	-0.30	[-0.40, -0.20]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	-0.35	[-0.59, -0.12]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.38	[-0.42, -0.34]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	-0.39	[-0.55, -0.23]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	-0.47	[-0.66, -0.29]	1	Logs
➖	quality_gate_security_no_fs_load	memory utilization	-0.83	[-0.94, -0.73]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	-1.52	[-1.77, -1.28]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	695 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	241.65MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	725 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.21GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	139.27MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	468.24MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	175.79MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	338.43 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	363.15MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	24.11 ≤ 40	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	287.29MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	54.19 ≤ 70	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	266.61MiB ≤ 320MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	19.09 ≤ 40	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	274.23MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.

### What does this PR do? - migrate `pkg/proto/datadog/trace` from `gazelle`-excluded to `gazelle`-managed with: - `proto_library` + `go_proto_library` (standard), - `write_pb_go` in `pkg/proto/pbgo/trace/idx`: keeps `span.pb.go` and `tracer_payload.pb.go` in sync with the proto-generated output, - add `# gazelle:resolve` in the root `BUILD.bazel` to disambiguate `idx_go_proto` (`importpath` = full module path) from the existing `go_library` in `pkg/proto/pbgo/trace/idx`, - add `# gazelle:write_pb_go off` to `pkg/proto/pbgo/trace` to defer its `write_pb_go` until `protoc-go-inject-tag` and `msgp` can be plugged into `//pkg/proto/datadog/trace:trace_go_proto`, - move `trace/idx` out of `PROTO_PKGS` in `tasks/protobuf.py`, delegating `.pb.go` generation to the topmost `bazel` command: `bazel run //pkg/proto/pbgo/trace/idx:write_pb_go` (left for didactic purposes). ### Motivation Enable `bazel` to verify that the committed `span.pb.go` and `tracer_payload.pb.go` in `trace/idx` stay in sync with their proto source, using the `write_pb_go` adapter introduced in #49770. See precedent _partially_ established by #49918 (`languagedetection`, _partially_ because it missed the corresponding `protobuf.py` change - addressed by #50394). ### Describe how you validated your changes - `bazel run //:gazelle` produced no new warnings (stable), - `bazel test //pkg/proto/pbgo/trace/idx:write_pb_go_tests` passes, - `dda inv protobuf.generate` succeeds. ### Additional Notes The main `trace/` package is deferred because its `.pb.go` files are post-processed by `protoc-go-inject-tag` and `msgp`, not yet wired into `bazel`. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>

### What does this PR do? - migrate `pkg/proto/datadog/trace` from `gazelle`-excluded to `gazelle`-managed with: - `proto_library` + `go_proto_library` (standard), - `write_pb_go` in `pkg/proto/pbgo/trace/idx`: keeps `span.pb.go` and `tracer_payload.pb.go` in sync with the proto-generated output, - add `# gazelle:resolve` in the root `BUILD.bazel` to disambiguate `idx_go_proto` (`importpath` = full module path) from the existing `go_library` in `pkg/proto/pbgo/trace/idx`, - add `# gazelle:write_pb_go off` to `pkg/proto/pbgo/trace` to defer its `write_pb_go` until `protoc-go-inject-tag` and `msgp` can be plugged into `//pkg/proto/datadog/trace:trace_go_proto`, - move `trace/idx` out of `PROTO_PKGS` in `tasks/protobuf.py`, delegating `.pb.go` generation to the topmost `bazel` command: `bazel run //pkg/proto/pbgo/trace/idx:write_pb_go` (left for didactic purposes). ### Motivation Enable `bazel` to verify that the committed `span.pb.go` and `tracer_payload.pb.go` in `trace/idx` stay in sync with their proto source, using the `write_pb_go` adapter introduced in DataDog#49770. See precedent _partially_ established by DataDog#49918 (`languagedetection`, _partially_ because it missed the corresponding `protobuf.py` change - addressed by DataDog#50394). ### Describe how you validated your changes - `bazel run //:gazelle` produced no new warnings (stable), - `bazel test //pkg/proto/pbgo/trace/idx:write_pb_go_tests` passes, - `dda inv protobuf.generate` succeeds. ### Additional Notes The main `trace/` package is deferred because its `.pb.go` files are post-processed by `protoc-go-inject-tag` and `msgp`, not yet wired into `bazel`. Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com> a00f465

rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels May 5, 2026

dd-octo-sts Bot added the internal Identify a non-fork PR label May 5, 2026

rdesgroppes marked this pull request as ready for review May 5, 2026 16:41

rdesgroppes requested a review from a team as a code owner May 5, 2026 16:41

github-actions Bot added the short review PR is simple enough to be reviewed quickly label May 5, 2026

dd-octo-sts Bot added the team/agent-devx label May 5, 2026

rdesgroppes mentioned this pull request May 5, 2026

[ABLD-387] bazelify proto generation: trace/idx #50390

Merged

KevinFairise2 approved these changes May 6, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit f7a74eb into main May 6, 2026
280 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the regis.desgroppes/write-pb-go-languagedetection-protobuf branch May 6, 2026 14:18

github-actions Bot added this to the 7.80.0 milestone May 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`bazel`ify proto generation: `languagedetection` leftover#50394

`bazel`ify proto generation: `languagedetection` leftover#50394
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
regis.desgroppes/write-pb-go-languagedetection-protobuf

rdesgroppes commented May 5, 2026 •

edited

Loading

Uh oh!

datadog-official Bot commented May 5, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

Uh oh!

dd-octo-sts Bot commented May 5, 2026

Uh oh!

dd-octo-sts Bot commented May 5, 2026

Uh oh!

cit-pr-commenter-54b7da Bot commented May 5, 2026 •

edited

Loading

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rdesgroppes commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Uh oh!

datadog-official Bot commented May 5, 2026 • edited by datadog-prod-us1-3 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dd-octo-sts Bot commented May 5, 2026

Files inventory check summary

Results for datadog-agent_7.80.0~devel.git.492.03471d7.pipeline.111545547-1_amd64.deb:

Uh oh!

dd-octo-sts Bot commented May 5, 2026

Static quality checks

Uh oh!

cit-pr-commenter-54b7da Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Fine details of change detection per experiment

Bounds Checks: ✅ Passed

Explanation

CI Pass/Fail Decision

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rdesgroppes commented May 5, 2026 •

edited

Loading

datadog-official Bot commented May 5, 2026 •

edited by datadog-prod-us1-3 Bot

Loading

cit-pr-commenter-54b7da Bot commented May 5, 2026 •

edited

Loading