Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the Terraform Provider for Datadog there is a missing feature for uploading SAML Metadata XML file.
The endpoint for doing that already exists in Datadog API: Upload IdP Metadata. It is also implemented in this repo.
The endpoint references to version V2 and has only one subpath. That's why I decided to create a new structure called "Saml Configurations" -> like the last but one subpath in endpoint. For now the structure contains only IdpMetadata but using this approach will let others extend this feature in the future.
The provided structure is created based on other models in
api/datadogV2
directory and is used in the PR in Terraform Provider for Datadog repo.Additional Notes
This PR should be merged first. Then I can reference a stable version of this repo in the go.mod in Terraform Provider for Datadog.
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.