Kustomize foundations: model, bounded filesystem, Helm renderer#111
Kustomize foundations: model, bounded filesystem, Helm renderer#111whitemerch wants to merge 3 commits into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 79096eb | Docs | Datadog PR Page | Give us feedback! |
7338570 to
ec13e91
Compare
MikaYuoadas
left a comment
There was a problem hiding this comment.
This PR is very big, its sheer size overflow the context of my limited brainpower (there’s only so much token available before my brains gives up 😆 ).
But I’ve done my best to read it all and left a few comments on minor issues I found.
Otherwise the main thing I’m concerned about is not in the code itself but on the decision to surface resolver failure as vulnerability that IIUC will be added to the final SARIF output and will create customer facing findings. Is that intended design? I find it quite strange, and if we want to do so it may warrant more product discussion. We are a security product, not a linter for syntax error. IMHO findings about syntax error is not something customers expect to see in IaC explorer. (but correct me if I understood it wrong).
@MikaYuoadas Nop, you are totally right. I misunderstood this part of the code, I needed a way to report non-fatal resolver problems while still continuing the scan, but I will mimick the Helm behavior for now |
e8b5084 to
a58d6bf
Compare
a58d6bf to
79096eb
Compare
Tip
This PR is best reviewed commit by commit.
Summary
Full design context and architecture details: #113
Test plan
go test ./cmd/scanner ./pkg/featureflags ./pkg/kics ./pkg/resolver/helm ./pkg/resolver/sandbox ./pkg/scannergit diff --check origin/mainNon-goals