Skip Helm library charts in resolver#172
Merged
Merged
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: b65148e | Docs | Datadog PR Page | Give us feedback! |
whitemerch
changed the title
whitemerch
force-pushed
the
chakib.hamie/skip_helm_library_charts
branch
from
7300569 to
36ee4d3
Compare
whitemerch
force-pushed
the
chakib.hamie/skip_helm_library_charts
branch
from
36ee4d3 to
b65148e
Compare
ChouraquiBen
approved these changes
Jun 3, 2026
Contributor
ChouraquiBen
left a comment
ChouraquiBen
left a comment
There was a problem hiding this comment.
I don't think it is blocking but one question
| if err == nil { | ||
| return model.KindHELM | ||
| chartFS := os.DirFS(filepath.Clean(filePath)) | ||
| data, err := fs.ReadFile(chartFS, "Chart.yaml") |
Contributor
There was a problem hiding this comment.
Question: I have rarely seen fs.ReadFile used, usually, it is os.ReadFile, is there a reason why using fs.ReadFile here?
Contributor
Author
There was a problem hiding this comment.
I used os.ReadFile and it made go-ci fail from what I recall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Helm library charts (
type: library) cannot be installed; the scanner was still running the Helm dry-run path and logging errors such aschart is not installable: library charts are not installable (only 'application' type charts are supported), which added noise toservice:iac-scanningwithout improving coverage (library charts have no deployable manifests).Changes
Resolver
GetTypereadsChart.yamland returnsKindCOMMONfortype: library, so the Helm resolver is not invoked for those directories (same skip behavior as non-chart paths).Tests
Fixture
test/fixtures/test_helm_libraryandTestGetTypecases for application vs library charts.Author Checklist
QA Instruction
CI should pass.
Blast Radius
Only the Helm classification path in
pkg/resolver; library chart directories are no longer passed to the Helm renderer.Additional Notes
I submit this contribution under the Apache-2.0 license.