Merge pull request #786 from DataDog/carlosnogueira/RUM-1206/add-tele…

…metry-to-apollo-client

[RUM-1206] Add telemetry to apollo client

packages/core/src/index.tsx

@@ -14,6 +14,7 @@ import {
     BatchSize
 } from './DdSdkReactNativeConfiguration';
 import { DdSdkReactNative } from './DdSdkReactNative';
+import { DdSdk } from './sdk/DdSdk';
 import { InternalLog } from './InternalLog';
 import { ProxyConfiguration, ProxyType } from './ProxyConfiguration';
 import { SdkVerbosity } from './SdkVerbosity';
@@ -48,6 +49,7 @@ export {
     ErrorSource,
     DdSdkReactNativeConfiguration,
     DdSdkReactNative,
+    DdSdk,
     InternalLog,
     ProxyConfiguration,
     ProxyType,

packages/react-native-apollo-client/package.json

@@ -45,7 +45,7 @@
     },
     "peerDependencies": {
         "@apollo/client": ">=3.0",
-        "@datadog/mobile-react-native": "^2.0.1",
+        "@datadog/mobile-react-native": "^2.6.1",
         "react": ">=16.13.1",
         "react-native": ">=0.63.4 <1.0"
     },

packages/react-native-apollo-client/src/helpers.ts

@@ -8,15 +8,28 @@
  * NOTE: Do not import from '@apollo/client/utilities' as the package does not exist in Apollo Client < v3.
  */
 
+import { version } from '@apollo/client/package.json';
 import type { Operation } from '@apollo/client';
+import { DdSdk } from '@datadog/mobile-react-native';
 import type { DefinitionNode, OperationDefinitionNode } from 'graphql';
 
+import { ErrorCode, errorMessages } from './types';
+
+const apolloVersion = `[Apollo v${version}]`;
+
 export const getVariables = (operation: Operation): string | null => {
     if (operation.variables) {
         try {
             return JSON.stringify(operation.variables);
         } catch (e) {
-            // TODO RUM-1206: telemetry
+            DdSdk?.telemetryError(
+                _getErrorMessage(
+                    ErrorCode.GQL_VARIABLE_RETRIEVAL_ERROR,
+                    apolloVersion
+                ),
+                _getErrorStack(e),
+                ErrorCode.GQL_VARIABLE_RETRIEVAL_ERROR
+            );
             return null;
         }
     }
@@ -48,7 +61,24 @@ export const getOperationType = (
                 })[0] || null
         );
     } catch (e) {
-        // TODO RUM-1206: telemetry
+        DdSdk?.telemetryError(
+            _getErrorMessage(ErrorCode.GQL_OPERATION_TYPE_ERROR, apolloVersion),
+            _getErrorStack(e),
+            ErrorCode.GQL_OPERATION_TYPE_ERROR
+        );
         return null;
     }
 };
+
+const _getErrorMessage = (code: ErrorCode, details: string) =>
+    `${errorMessages[code]} - ${details}`;
+
+const _getErrorStack = (error: unknown): string => {
+    if (!error) {
+        return '';
+    }
+
+    return error instanceof Error
+        ? error.stack ?? 'No stack trace available'
+        : `Non-Error thrown: ${error}`;
+};

packages/react-native-apollo-client/src/types.ts

@@ -0,0 +1,11 @@
+export const enum ErrorCode {
+    GQL_VARIABLE_RETRIEVAL_ERROR = 'GQL_VARIABLE_RETRIEVAL_ERROR',
+    GQL_OPERATION_TYPE_ERROR = 'GQL_OPERATION_TYPE_ERROR'
+}
+
+export const errorMessages: Record<ErrorCode, string> = {
+    [ErrorCode.GQL_VARIABLE_RETRIEVAL_ERROR]:
+        'Failed to retrieve GraphQL variables from operation',
+    [ErrorCode.GQL_OPERATION_TYPE_ERROR]:
+        'Failed to determine GraphQL operation type'
+};

yarn.lock

@@ -2909,7 +2909,7 @@ __metadata:
     react-native-builder-bob: 0.26.0
   peerDependencies:
     "@apollo/client": ">=3.0"
-    "@datadog/mobile-react-native": ^2.0.1
+    "@datadog/mobile-react-native": ^2.6.1
     react: ">=16.13.1"
     react-native: ">=0.63.4 <1.0"
   languageName: unknown