Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "non-prod ready" notice for apollo client integration #588

Merged

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

We're now surfacing the graphql requests information on the frontend, so we can remove this notice in the README.

Additional Notes

This will be propagated to https://www.npmjs.com/package/@datadog/mobile-react-native-apollo-client with the next release.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested review from a team as code owners January 16, 2024 15:13
@louiszawadzki louiszawadzki merged commit b1f9b32 into develop Jan 16, 2024
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/remove-alpha-notice-for-graphql branch January 16, 2024 16:36
@stevoland
Copy link
Contributor

Hi @louiszawadzki, me again :)

In what way is this to be exposed in the UI? I see the graphql.operationName etc attributes on the resource but nothing built into the UI. Is something being rolled out perhaps?

@louiszawadzki
Copy link
Contributor Author

Hi @stevoland!
Yes it will be announced and rolled out in the coming days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants