Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types path for apollo client package #589

Conversation

louiszawadzki
Copy link
Contributor

What does this PR do?

For some packages (I think it is if we import from the core package in the package), the typescript file structure will be different.
I didn't notice that the types were not found for the apollo client integration before, now it is fixed.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@louiszawadzki louiszawadzki requested a review from a team as a code owner January 17, 2024 15:28
@louiszawadzki louiszawadzki merged commit cbe56ed into develop Jan 17, 2024
4 checks passed
@louiszawadzki louiszawadzki deleted the louiszawadzki/fix-ts-definition-path-for-graphql-package branch January 17, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants