Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session Replay] Session Replay v2.5.0 features #754

Merged
merged 12 commits into from
Dec 19, 2024

Conversation

marco-saia-datadog
Copy link
Member

What does this PR do?

This PR contains all the new Session Replay features and changes that will be rolled out in v2.5.0.

Motivation

This PR serves as a convenient way to test all features before merging them in develop.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 19, 2024

Datadog Report

Branch report: marcosaia/release/v2.5.0-rc0
Commit report: 89676a8
Test service: dd-sdk-reactnative

✅ 0 Failed, 629 Passed, 1 Skipped, 15.09s Total Time

@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review December 19, 2024 11:56
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner December 19, 2024 11:56
if (drawable.intrinsicWidth * drawable.intrinsicHeight > width * height) {
width = drawable.intrinsicWidth
height = drawable.intrinsicHeight
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite clear with that, why do we compare the product and not values individually?

Should it just be width = max(width, drawable.intrinsicWidth) and height = max(height, drawable.intrinsicHeight) without if check?

Copy link
Member Author

@marco-saia-datadog marco-saia-datadog Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to cover edge cases in which only the width or only the height are either 0 or -1, and only override the values if the overall size is bigger.

I used the area for cases like this:

Size1 = 20x200
Size2 = 50x150

With my logic it would pick 50x150, with the individual assignments it would be a new size of 50x200.

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/release/v2.5.0-rc0 branch 2 times, most recently from c893489 to da99c9d Compare December 19, 2024 13:24
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/release/v2.5.0-rc0 branch from da99c9d to c996b92 Compare December 19, 2024 13:30
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/release/v2.5.0-rc0 branch 2 times, most recently from 89676a8 to b53e0bb Compare December 19, 2024 13:54
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/release/v2.5.0-rc0 branch from b53e0bb to b216493 Compare December 19, 2024 13:58
@marco-saia-datadog marco-saia-datadog merged commit 344af53 into develop Dec 19, 2024
9 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/release/v2.5.0-rc0 branch December 19, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants