-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Session Replay] Session Replay v2.5.0 features #754
Conversation
…aia/release/v2.5.0-rc0
…osaia/release/v2.5.0-rc0
[RUM-7799] Android: new architecture fixes
Datadog ReportBranch report: ✅ 0 Failed, 629 Passed, 1 Skipped, 15.09s Total Time |
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Outdated
Show resolved
Hide resolved
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Outdated
Show resolved
Hide resolved
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Outdated
Show resolved
Hide resolved
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Outdated
Show resolved
Hide resolved
if (drawable.intrinsicWidth * drawable.intrinsicHeight > width * height) { | ||
width = drawable.intrinsicWidth | ||
height = drawable.intrinsicHeight | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite clear with that, why do we compare the product and not values individually?
Should it just be width = max(width, drawable.intrinsicWidth)
and height = max(height, drawable.intrinsicHeight)
without if
check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to cover edge cases in which only the width or only the height are either 0 or -1, and only override the values if the overall size is bigger.
I used the area for cases like this:
Size1 = 20x200
Size2 = 50x150
With my logic it would pick 50x150
, with the individual assignments it would be a new size of 50x200
.
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Outdated
Show resolved
Hide resolved
...android/src/main/kotlin/com/datadog/reactnative/sessionreplay/mappers/ReactEditTextMapper.kt
Outdated
Show resolved
Hide resolved
c893489
to
da99c9d
Compare
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Outdated
Show resolved
Hide resolved
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Show resolved
Hide resolved
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Show resolved
Hide resolved
...ndroid/src/main/kotlin/com/datadog/reactnative/sessionreplay/extensions/ReactDrawablesExt.kt
Outdated
Show resolved
Hide resolved
...android/src/main/kotlin/com/datadog/reactnative/sessionreplay/mappers/ReactEditTextMapper.kt
Outdated
Show resolved
Hide resolved
da99c9d
to
c996b92
Compare
89676a8
to
b53e0bb
Compare
b53e0bb
to
b216493
Compare
...android/src/main/kotlin/com/datadog/reactnative/sessionreplay/mappers/ReactEditTextMapper.kt
Outdated
Show resolved
Hide resolved
[RUM-6028] Fix drawable custom logic for RN 0.75 and 0.76
What does this PR do?
This PR contains all the new Session Replay features and changes that will be rolled out in v2.5.0.
Motivation
This PR serves as a convenient way to test all features before merging them in develop.
Review checklist (to be filled by reviewers)