Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo.silva - Expose TracingIdType and improved generateUUID method by adding paddex and decimal format, so it can propragate correctly the trace context. #759

Closed

Conversation

jhssilva
Copy link
Contributor

@jhssilva jhssilva commented Dec 20, 2024

What does this PR do?

  • Add Expose TracingIdType on SDK
  • Update DDRum and DdRUm.test: Improved generateUUID method, by adding paddex and Decimal format

Motivation

The UUID being generated wasn't complying with the expectations to generate the trace on RUM.

Additional Notes

  • I've tested in the Application with the ids being generated and traces were generated.
image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@jhssilva jhssilva requested a review from a team as a code owner December 20, 2024 17:41
@jhssilva
Copy link
Contributor Author

@marco-saia-datadog FYI

@jhssilva jhssilva changed the title hugo.silva/improve generate uuid hugo.silva - Expose TracingIdType and improved generateUUID method by adding paddex and decimal format, so it can propragate correctly the trace context. Dec 25, 2024
@marco-saia-datadog marco-saia-datadog added the Do not merge This PR is not ready to be merged yet label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge This PR is not ready to be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants