Fix example projects #776
Merged
Fix example projects #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
example/src/WixApp.tsx
Outdated
Comment on lines
15
to
20
| const viewPredicate: ViewNamePredicate = function customViewNamePredicate( | ||
| _event: ComponentDidAppearEvent, | ||
| trackedName: string | ||
| ) { | ||
| return 'Custom RNN ' + trackedName; | ||
| }; |
There was a problem hiding this comment.
⚪ Code Quality Violation
Function name 'customViewNamePredicate' should match name 'viewPredicate'. (...read more)
Use the same name between your function declaration and the variable or property to which it is assigned.
Datadog ReportBranch report: ✅ 0 Failed, 630 Passed, 1 Skipped, 12.1s Total Time |
- Upgrade react-native to version 0.74.6 - Update project dependencies - Fix metro & babel configs - Upgrade gradle version - Increase minSdkVersion & ndkVersion - Update 'WixApp' component to access 'Navigation' object from '@datadog/mobile-react-native-navigation'
…rade - Upgrade react-native to version 0.74.6 - Update project dependencies - Fix metro config - Upgrade gradle version - Increase minSdkVersion & ndkVersion - Remove flipper initialization & refactor 'MainApplication.kt' - Rename 'getBundleURL' to 'bundleURL' in 'AppDelegate.mm'
cdn34dd
force-pushed
the
carlosnogueira/RUM-8045/fix-example-projects
branch
from
b1f9c39 to
48bfff3
Compare
marco-saia-datadog
force-pushed
the
carlosnogueira/RUM-8045/fix-example-projects
branch
from
48bfff3 to
aeda8cb
Compare
Datadog ReportBranch report: ✅ 0 Failed, 630 Passed, 1 Skipped, 12.22s Total Time |
marco-saia-datadog
previously approved these changes
Jan 27, 2025
Comment on lines
6
to
10
| includeBuild('../node_modules/@react-native/gradle-plugin') | ||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| includeBuild('../node_modules/@react-native/gradle-plugin') | |
| includeBuild('../node_modules/@react-native/gradle-plugin') | |
example/android/app/build.gradle
Outdated
| @@ -125,5 +116,4 @@ dependencies { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) | |||
| // apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) | |||
There was a problem hiding this comment.
Suggested change
| // apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) |
example/babel.config.js
Outdated
Comment on lines
8
to
31
| // plugins: [ | ||
| // [ | ||
| // 'module-resolver', | ||
| // { | ||
| // alias: { | ||
| // [pakCore.name]: path.join( | ||
| // __dirname, | ||
| // '../packages/core', | ||
| // pakCore.source, | ||
| // ), | ||
| // [pakNavigation.name]: path.join( | ||
| // __dirname, | ||
| // '../packages/react-navigation', | ||
| // pakNavigation.source, | ||
| // ), | ||
| // [pakNativeNavigation.name]: path.join( | ||
| // __dirname, | ||
| // '../packages/react-native-navigation', | ||
| // pakNativeNavigation.source, | ||
| // ), | ||
| // }, | ||
| // }, | ||
| // ], | ||
| // ], |
There was a problem hiding this comment.
Let's clean this up if not needed anymore 🧹
example/src/WixApp.tsx
Outdated
Comment on lines
15
to
20
| const viewPredicate: ViewNamePredicate = function customViewNamePredicate( | ||
| _event: ComponentDidAppearEvent, | ||
| trackedName: string | ||
| ) { | ||
| return 'Custom RNN ' + trackedName; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const viewPredicate: ViewNamePredicate = function customViewNamePredicate( | |
| _event: ComponentDidAppearEvent, | |
| trackedName: string | |
| ) { | |
| return 'Custom RNN ' + trackedName; | |
| }; | |
| const viewPredicate: ViewNamePredicate = function viewPredicate( | |
| _event: ComponentDidAppearEvent, | |
| trackedName: string | |
| ) { | |
| return 'Custom RNN ' + trackedName; | |
| }; |
or
Suggested change
| const viewPredicate: ViewNamePredicate = function customViewNamePredicate( | |
| _event: ComponentDidAppearEvent, | |
| trackedName: string | |
| ) { | |
| return 'Custom RNN ' + trackedName; | |
| }; | |
| const viewPredicate: ViewNamePredicate = ( | |
| _event: ComponentDidAppearEvent, | |
| trackedName: string | |
| ) => { | |
| return 'Custom RNN ' + trackedName; | |
| }; |
cdn34dd
force-pushed
the
carlosnogueira/RUM-8045/fix-example-projects
branch
from
2c3ed01 to
893a35e
Compare
marco-saia-datadog
approved these changes
Jan 28, 2025
marco-saia-datadog
deleted the
carlosnogueira/RUM-8045/fix-example-projects
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix both example and example-new-architecture and update projects to latest supported react-native version.