[RUM-5332] Fix text properties for android new architecture #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdn34dd
changed the title
Datadog ReportBranch report: ✅ 0 Failed, 630 Passed, 1 Skipped, 12.48s Total Time |
cdn34dd
changed the title
cdn34dd
force-pushed
the
carlosnogueira/RUM-5332/unresolved-rn-text-propertie-new-arch
branch
from
4cc98a6 to
f1e924f
Compare
- refactor code to handle legacy/fabric architectures separately - update unit tests
cdn34dd
force-pushed
the
carlosnogueira/RUM-5332/unresolved-rn-text-propertie-new-arch
branch
from
f1e924f to
33728a4
Compare
marco-saia-datadog
approved these changes
Feb 17, 2025
marco-saia-datadog
deleted the
carlosnogueira/RUM-5332/unresolved-rn-text-propertie-new-arch
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Aims to fix text properties’ resolution in react-native new architecture and also to simplify text mappers’ processing flow when having to target both legacy and fabric architectures.
Review checklist (to be filled by reviewers)