[FIX] Allow using a custom error fingerprint in simple error logs #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
force-pushed
the
marcosaia/fix/simple-error-logs-fingerprint
branch
from
9065fc7 to
960814f
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| return logEvent; | ||
| }); | ||
|
|
||
| console.error('test-error'); |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unexpected console statement. (...read more)
Debugging with console is not considered a bad practice, but it's easy to forget about console statements and leave them in production code. There is no need to pollute production builds with debugging statements.
| }; | ||
|
|
||
| export const formatRawLogToNativeEvent = ( | ||
| rawLog: RawLog | RawLogWithError | ||
| ): NativeLog | NativeLogWithError => { | ||
| if ((rawLog as RawLogWithError).fingerprint) { | ||
| (rawLog.context as any)[ |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unsafe assignment of an `any` value. (...read more)
The any type in TypeScript is dangerously broad, leading to unexpected behavior. Using any should be avoided.
| return (this.context as any)[DdAttributes.errorFingerprint] as string; | ||
| } | ||
| public set fingerprint(value: string | undefined) { | ||
| (this.context as any)[DdAttributes.errorFingerprint] = value; |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unsafe assignment of an `any` value. (...read more)
The any type in TypeScript is dangerously broad, leading to unexpected behavior. Using any should be avoided.
| attributes?: object | undefined; | ||
|
|
||
| public get fingerprint(): string | undefined { | ||
| return (this.context as any)[DdAttributes.errorFingerprint] as string; |
There was a problem hiding this comment.
🟠 Code Quality Violation
Unsafe assignment of an `any` value. (...read more)
The any type in TypeScript is dangerously broad, leading to unexpected behavior. Using any should be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows passing a custom error fingerprint to error logs that consist of only a message and an optional context.
Motivation
It is currently possible to use a custom error fingerprint for logs with error, but not for simple logs that only have a message and an optional context.
Review checklist (to be filled by reviewers)