Skip to content

Add helper DictionaryExtensions.SequenceEqual #7722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: andrew/settings/4a-block-uds-windows
Choose a base branch
from
Open

Add helper DictionaryExtensions.SequenceEqual #7722

wants to merge 1 commit into from
+147 −0

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Oct 28, 2025 •
edited
Loading

Summary of changes

Add a helper for comparing ReadOnlyDictionary<> instances

Reason for change

As part of the config work, we need to detect if tags have changed when customers do a manual/remote config update. This helper makes it easy

Implementation details

Added a SequenceEqual extension method.

Note that I used SequenceEqual because it already exists in System.Linq, but I could see an argument that it's too easy to use the wrong one, and instead we could use a different name? IsSameAs(other)?

Also, I only wrote this for ReadOnlyDictionary<> because that's all we need, it's what we use for all our setting dictionaries, and it will be (a tiny bit) faster than making it IDictionary<>, but happy to change if people feel strongly.

Test coverage

Added unit tests

Other details

https://datadoghq.atlassian.net/browse/LANGPLAT-819

Part of a config stack

@andrewlock andrewlock requested a review from a team as a code owner October 28, 2025 13:41
This was referenced Oct 28, 2025
Open
Open
Open
Open
@pr-commenter
Copy link

pr-commenter bot commented Oct 28, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7722 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.169
  • 1 benchmarks are slower, with geometric mean 2.454
  • 6 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7722

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.11 KB 6.06 KB -50 B -0.82%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.7μs 55.6ns 289ns 0 0 0 5.51 KB
master StartStopWithChild netcoreapp3.1 13.6μs 68.7ns 315ns 0 0 0 5.7 KB
master StartStopWithChild net472 22.1μs 117ns 585ns 0.893 0.223 0 6.11 KB
#7722 StartStopWithChild net6.0 10.6μs 57.5ns 315ns 0 0 0 5.52 KB
#7722 StartStopWithChild netcoreapp3.1 13.7μs 39.5ns 142ns 0 0 0 5.69 KB
#7722 StartStopWithChild net472 21.5μs 113ns 578ns 0.99 0.33 0.11 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 645ns 2.5μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 85.2ns 307ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 77.5ns 300ns 0 0 0 3.31 KB
#7722 WriteAndFlushEnrichedTraces net6.0 919μs 63.7ns 238ns 0 0 0 2.71 KB
#7722 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 147ns 571ns 0 0 0 2.7 KB
#7722 WriteAndFlushEnrichedTraces net472 1.2ms 170ns 587ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleSimpleBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleSimpleBody net472 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody net472 N/A N/A N/A NaN NaN NaN 0 b
master ObjectExtractorSimpleBody net6.0 316ns 1.71ns 9.36ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 406ns 2.24ns 12.7ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 302ns 0.0515ns 0.199ns 0.044 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.3μs 31.1ns 139ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.86μs 38.1ns 162ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.67μs 1.66ns 6.41ns 0.6 0 0 3.8 KB
#7722 AllCycleSimpleBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7722 AllCycleSimpleBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7722 AllCycleSimpleBody net472 N/A N/A N/A NaN NaN NaN 0 b
#7722 AllCycleMoreComplexBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7722 AllCycleMoreComplexBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7722 AllCycleMoreComplexBody net472 N/A N/A N/A NaN NaN NaN 0 b
#7722 ObjectExtractorSimpleBody net6.0 324ns 1.66ns 7.45ns 0 0 0 280 B
#7722 ObjectExtractorSimpleBody netcoreapp3.1 402ns 2.05ns 9.6ns 0 0 0 272 B
#7722 ObjectExtractorSimpleBody net472 297ns 0.075ns 0.291ns 0.0433 0 0 281 B
#7722 ObjectExtractorMoreComplexBody net6.0 6.34μs 29.4ns 114ns 0 0 0 3.78 KB
#7722 ObjectExtractorMoreComplexBody netcoreapp3.1 7.95μs 31.1ns 121ns 0 0 0 3.69 KB
#7722 ObjectExtractorMoreComplexBody net472 6.7μs 5.23ns 20.3ns 0.601 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.3μs 85.6ns 331ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.8μs 267ns 1.03μs 0 0 0 32.4 KB
master EncodeArgs net472 111μs 9.95ns 38.5ns 5.02 0 0 32.5 KB
master EncodeLegacyArgs net6.0 143μs 36.6ns 142ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 198μs 272ns 1.05μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 145ns 562ns 0 0 0 2.16 KB
#7722 EncodeArgs net6.0 78.2μs 52.2ns 195ns 0 0 0 32.4 KB
#7722 EncodeArgs netcoreapp3.1 97.4μs 281ns 1.09μs 0 0 0 32.4 KB
#7722 EncodeArgs net472 109μs 17.6ns 68.3ns 4.93 0 0 32.5 KB
#7722 EncodeLegacyArgs net6.0 145μs 13.2ns 47.7ns 0 0 0 2.15 KB
#7722 EncodeLegacyArgs netcoreapp3.1 202μs 209ns 782ns 0 0 0 2.14 KB
#7722 EncodeLegacyArgs net472 263μs 95.5ns 344ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7722

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.454 299,521.88 734,970.50

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 393μs 78.7ns 295ns 0 0 0 4.56 KB
master RunWafRealisticBenchmark netcoreapp3.1 415μs 171ns 616ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 429μs 35.7ns 129ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 286μs 63.3ns 237ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 299μs 214ns 827ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 311μs 21.1ns 76.2ns 0 0 0 2.29 KB
#7722 RunWafRealisticBenchmark net6.0 394μs 60.4ns 234ns 0 0 0 4.55 KB
#7722 RunWafRealisticBenchmark netcoreapp3.1 408μs 127ns 458ns 0 0 0 4.48 KB
#7722 RunWafRealisticBenchmark net472 432μs 36ns 135ns 0 0 0 4.66 KB
#7722 RunWafRealisticBenchmarkWithAttack net6.0 289μs 198ns 765ns 0 0 0 2.24 KB
#7722 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 681μs 11.6μs 116μs 0 0 0 2.22 KB
#7722 RunWafRealisticBenchmarkWithAttack net472 309μs 31.6ns 122ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.7μs 58.7ns 220ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 70.9μs 162ns 586ns 0 0 0 17.42 KB
master SendRequest net472 0.00244ns 0.000969ns 0.00375ns 0 0 0 0 b
#7722 SendRequest net6.0 60.9μs 222ns 831ns 0 0 0 14.52 KB
#7722 SendRequest netcoreapp3.1 71.2μs 166ns 599ns 0 0 0 17.42 KB
#7722 SendRequest net472 0.00236ns 0.00156ns 0.00603ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7722

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 5 B 2 B -3 B -60.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 51 B 0 b -51 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.91ms 3.51μs 13.6μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.09ms 3μs 10.8μs 0 0 0 640 KB
master OriginalCharSlice net472 2.55ms 116ns 451ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.4ms 932ns 3.61μs 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.82ms 444ns 1.72μs 0 0 0 1 B
master OptimizedCharSlice net472 1.97ms 315ns 1.18μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 898μs 45.5ns 176ns 0 0 0 5 B
master OptimizedCharSliceWithPool netcoreapp3.1 816μs 83.9ns 314ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.15ms 120ns 464ns 0 0 0 51 B
#7722 OriginalCharSlice net6.0 1.98ms 3.73μs 14.4μs 0 0 0 640.01 KB
#7722 OriginalCharSlice netcoreapp3.1 2.15ms 7.74μs 29μs 0 0 0 640 KB
#7722 OriginalCharSlice net472 2.63ms 458ns 1.71μs 100 0 0 641.95 KB
#7722 OptimizedCharSlice net6.0 1.38ms 207ns 800ns 0 0 0 4 B
#7722 OptimizedCharSlice netcoreapp3.1 1.66ms 289ns 1.12μs 0 0 0 1 B
#7722 OptimizedCharSlice net472 1.9ms 338ns 1.31μs 0 0 0 0 b
#7722 OptimizedCharSliceWithPool net6.0 821μs 93.8ns 363ns 0 0 0 2 B
#7722 OptimizedCharSliceWithPool netcoreapp3.1 855μs 47.9ns 186ns 0 0 0 0 b
#7722 OptimizedCharSliceWithPool net472 1.16ms 158ns 569ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #7722

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.194 782,873.08 655,758.93

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 709μs 3.92μs 25.1μs 0 0 0 41.77 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 764μs 4.41μs 35μs 0 0 0 41.77 KB
master WriteAndFlushEnrichedTraces net472 967μs 5.38μs 32.7μs 4.46 0 0 56.12 KB
#7722 WriteAndFlushEnrichedTraces net6.0 663μs 2.8μs 10.1μs 0 0 0 41.86 KB
#7722 WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 2.51μs 9.73μs 0 0 0 41.93 KB
#7722 WriteAndFlushEnrichedTraces net472 875μs 3.95μs 14.8μs 8.33 0 0 56.22 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #7722

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.144 2,942.54 2,571.33

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.94μs 5.14ns 17.8ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.93μs 11.7ns 45.2ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.83μs 3.88ns 15ns 0.155 0.0141 0 987 B
#7722 ExecuteNonQuery net6.0 1.84μs 0.842ns 3.26ns 0 0 0 1.02 KB
#7722 ExecuteNonQuery netcoreapp3.1 2.57μs 2.82ns 10.5ns 0 0 0 1.02 KB
#7722 ExecuteNonQuery net472 2.85μs 2.71ns 10.5ns 0.157 0.0143 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.73μs 2.01ns 7.79ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.21μs 8.11ns 31.4ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.76μs 6.48ns 25.1ns 0.149 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.86μs 7.73ns 27.9ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.34μs 11.2ns 44.7ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.75μs 1.82ns 7.05ns 0.167 0 0 1.1 KB
#7722 CallElasticsearch net6.0 1.73μs 2.85ns 11ns 0 0 0 1.03 KB
#7722 CallElasticsearch netcoreapp3.1 2.2μs 10.3ns 39.9ns 0 0 0 1.03 KB
#7722 CallElasticsearch net472 3.64μs 4ns 15.5ns 0.163 0 0 1.04 KB
#7722 CallElasticsearchAsync net6.0 1.79μs 9.74ns 42.5ns 0 0 0 1.01 KB
#7722 CallElasticsearchAsync netcoreapp3.1 2.42μs 8.94ns 34.6ns 0 0 0 1.08 KB
#7722 CallElasticsearchAsync net472 3.7μs 5.04ns 19.5ns 0.165 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.85μs 3.48ns 13.5ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.49μs 2.08ns 7.51ns 0 0 0 952 B
master ExecuteAsync net472 2.62μs 3.8ns 13.7ns 0.144 0 0 915 B
#7722 ExecuteAsync net6.0 1.93μs 7.87ns 29.5ns 0 0 0 952 B
#7722 ExecuteAsync netcoreapp3.1 2.43μs 6.78ns 26.3ns 0 0 0 952 B
#7722 ExecuteAsync net472 2.66μs 6.1ns 23.6ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.83μs 5.82ns 21.8ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.58μs 10.6ns 41.2ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 10.6ns 41.2ns 0.49 0 0 3.18 KB
#7722 SendAsync net6.0 6.88μs 13.1ns 50.7ns 0 0 0 2.36 KB
#7722 SendAsync netcoreapp3.1 8.67μs 29.1ns 113ns 0 0 0 2.9 KB
#7722 SendAsync net472 12.1μs 11.5ns 44.5ns 0.484 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7722

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 276.69 KB 281.22 KB 4.54 KB 1.64%

Fewer allocations 🎉 in #7722

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 275.74 KB -2.79 KB -1.00%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 275.52 KB 272.57 KB -2.95 KB -1.07%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 41μs 222ns 1.15μs 0 0 0 43.62 KB
master StringConcatBenchmark netcoreapp3.1 51.5μs 381ns 3.69μs 0 0 0 42.83 KB
master StringConcatBenchmark net472 56.7μs 222ns 917ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 477μs 1.03μs 3.55μs 0 0 0 276.69 KB
master StringConcatAspectBenchmark netcoreapp3.1 534μs 2.63μs 11.2μs 0 0 0 275.52 KB
master StringConcatAspectBenchmark net472 404μs 2.2μs 13.2μs 0 0 0 278.53 KB
#7722 StringConcatBenchmark net6.0 41.3μs 155ns 708ns 0 0 0 43.73 KB
#7722 StringConcatBenchmark netcoreapp3.1 49.1μs 271ns 1.88μs 0 0 0 42.74 KB
#7722 StringConcatBenchmark net472 56.9μs 257ns 961ns 0 0 0 57.34 KB
#7722 StringConcatAspectBenchmark net6.0 501μs 2.34μs 8.75μs 0 0 0 281.22 KB
#7722 StringConcatAspectBenchmark netcoreapp3.1 518μs 1.86μs 6.43μs 0 0 0 272.57 KB
#7722 StringConcatAspectBenchmark net472 406μs 2.19μs 11.8μs 0 0 0 275.74 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.67μs 2.89ns 11.2ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.56μs 17.7ns 73.2ns 0 0 0 1.7 KB
master EnrichedLog net472 3.84μs 2.02ns 7.81ns 0.25 0 0 1.64 KB
#7722 EnrichedLog net6.0 2.66μs 12.2ns 49ns 0 0 0 1.7 KB
#7722 EnrichedLog netcoreapp3.1 3.56μs 18.3ns 85.6ns 0 0 0 1.7 KB
#7722 EnrichedLog net472 3.9μs 4.01ns 15.5ns 0.252 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 143ns 516ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 414ns 1.55μs 0 0 0 4.31 KB
master EnrichedLog net472 167μs 131ns 506ns 0 0 0 4.52 KB
#7722 EnrichedLog net6.0 122μs 98.6ns 355ns 0 0 0 4.31 KB
#7722 EnrichedLog netcoreapp3.1 127μs 79.5ns 308ns 0 0 0 4.31 KB
#7722 EnrichedLog net472 168μs 38.8ns 135ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 21.3ns 82.6ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.7μs 22.5ns 87.2ns 0 0 0 2.26 KB
master EnrichedLog net472 7.73μs 10.4ns 40.4ns 0.309 0 0 2.08 KB
#7722 EnrichedLog net6.0 5.07μs 22.9ns 88.5ns 0 0 0 2.26 KB
#7722 EnrichedLog netcoreapp3.1 6.77μs 21.4ns 82.8ns 0 0 0 2.26 KB
#7722 EnrichedLog net472 7.51μs 4.91ns 18.4ns 0.301 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.97μs 6.48ns 25.1ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.76μs 9.28ns 34.7ns 0 0 0 1.2 KB
master SendReceive net472 2.99μs 1.84ns 7.11ns 0.179 0 0 1.2 KB
#7722 SendReceive net6.0 2.07μs 3.8ns 14.7ns 0 0 0 1.2 KB
#7722 SendReceive netcoreapp3.1 2.56μs 12ns 48.1ns 0 0 0 1.2 KB
#7722 SendReceive net472 3.02μs 3.59ns 13.9ns 0.183 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.42μs 0.87ns 3.26ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.69μs 10.6ns 41ns 0 0 0 1.63 KB
master EnrichedLog net472 6.46μs 4.67ns 17.5ns 0.29 0 0 2.03 KB
#7722 EnrichedLog net6.0 4.35μs 5.1ns 19.1ns 0 0 0 1.58 KB
#7722 EnrichedLog netcoreapp3.1 5.79μs 6.68ns 25ns 0 0 0 1.63 KB
#7722 EnrichedLog net472 6.69μs 8.79ns 34ns 0.297 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 767ns 1.54ns 5.96ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 979ns 3.6ns 14ns 0 0 0 576 B
master StartFinishSpan net472 950ns 0.189ns 0.706ns 0.0906 0 0 578 B
master StartFinishScope net6.0 918ns 4.33ns 16.8ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.22μs 5.72ns 22.1ns 0 0 0 696 B
master StartFinishScope net472 1.16μs 2.76ns 10.7ns 0.1 0 0 658 B
#7722 StartFinishSpan net6.0 769ns 4.38ns 25.2ns 0 0 0 576 B
#7722 StartFinishSpan netcoreapp3.1 952ns 5.13ns 29.5ns 0 0 0 576 B
#7722 StartFinishSpan net472 942ns 0.17ns 0.614ns 0.0896 0 0 578 B
#7722 StartFinishScope net6.0 927ns 4.87ns 23.3ns 0 0 0 696 B
#7722 StartFinishScope netcoreapp3.1 1.22μs 5.52ns 21.4ns 0 0 0 696 B
#7722 StartFinishScope net472 1.13μs 0.175ns 0.654ns 0.102 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.06μs 5.26ns 24.1ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.4μs 6.81ns 27.2ns 0 0 0 696 B
master RunOnMethodBegin net472 1.42μs 0.838ns 3.25ns 0.0994 0 0 658 B
#7722 RunOnMethodBegin net6.0 1.06μs 5.24ns 21.6ns 0 0 0 696 B
#7722 RunOnMethodBegin netcoreapp3.1 1.44μs 7.13ns 31.1ns 0 0 0 696 B
#7722 RunOnMethodBegin net472 1.5μs 1.6ns 6.18ns 0.0979 0 0 658 B

@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (83ms)  : crit, 73, 93
     .   : crit, milestone, 83,
    master - mean (71ms)  : 70, 73
     .   : milestone, 71,

    section Baseline
    This PR (7722) - mean (80ms)  : 71, 89
     .   : milestone, 80,
    master - mean (69ms)  : 62, 76
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (1,144ms)  : crit, 1049, 1239
     .   : crit, milestone, 1144,
    master - mean (1,045ms)  : 984, 1107
     .   : milestone, 1045,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (125ms)  : crit, 115, 135
     .   : crit, milestone, 125,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7722) - mean (120ms)  : 110, 131
     .   : milestone, 120,
    master - mean (105ms)  : 103, 107
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (819ms)  : crit, 770, 868
     .   : crit, milestone, 819,
    master - mean (745ms)  : 724, 766
     .   : milestone, 745,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (108ms)  : crit, 98, 118
     .   : crit, milestone, 108,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7722) - mean (107ms)  : 99, 115
     .   : milestone, 107,
    master - mean (93ms)  : 91, 94
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (763ms)  : crit, 713, 812
     .   : crit, milestone, 763,
    master - mean (702ms)  : 678, 726
     .   : milestone, 702,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (104ms)  : crit, 97, 111
     .   : crit, milestone, 104,
    master - mean (92ms)  : 91, 93
     .   : milestone, 92,

    section Baseline
    This PR (7722) - mean (105ms)  : 97, 114
     .   : milestone, 105,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (720ms)  : crit, 680, 760
     .   : crit, milestone, 720,
    master - mean (663ms)  : 646, 681
     .   : milestone, 663,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (199ms)  : 194, 204
     .   : milestone, 199,
    master - mean (196ms)  : 193, 199
     .   : milestone, 196,

    section Baseline
    This PR (7722) - mean (195ms)  : 190, 200
     .   : milestone, 195,
    master - mean (192ms)  : 187, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (1,166ms)  : 1104, 1228
     .   : milestone, 1166,
    master - mean (1,172ms)  : 1083, 1261
     .   : milestone, 1172,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (282ms)  : 277, 287
     .   : milestone, 282,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section Baseline
    This PR (7722) - mean (283ms)  : 276, 290
     .   : milestone, 283,
    master - mean (275ms)  : 270, 281
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (963ms)  : 924, 1002
     .   : milestone, 963,
    master - mean (940ms)  : 894, 986
     .   : milestone, 940,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (269ms)  : 265, 274
     .   : milestone, 269,
    master - mean (267ms)  : 265, 269
     .   : milestone, 267,

    section Baseline
    This PR (7722) - mean (270ms)  : 263, 278
     .   : milestone, 270,
    master - mean (268ms)  : 263, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (931ms)  : 883, 978
     .   : milestone, 931,
    master - mean (930ms)  : 880, 981
     .   : milestone, 930,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7722) - mean (269ms)  : 265, 273
     .   : milestone, 269,
    master - mean (270ms)  : 263, 277
     .   : milestone, 270,

    section Baseline
    This PR (7722) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (269ms)  : 264, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7722) - mean (854ms)  : 836, 873
     .   : milestone, 854,
    master - mean (851ms)  : 832, 870
     .   : milestone, 851,
Loading

@andrewlock andrewlock force-pushed the andrew/settings/4b-helper branch from 1ed4e84 to 1477479 Compare October 28, 2025 15:20
@andrewlock andrewlock requested a review from a team as a code owner October 28, 2025 15:20
@andrewlock andrewlock force-pushed the andrew/settings/4b-helper branch from 1477479 to e27c515 Compare October 28, 2025 18:13
@andrewlock andrewlock requested review from a team as code owners October 28, 2025 18:13
@andrewlock andrewlock requested review from link04 and removed request for a team October 28, 2025 18:13
@andrewlock andrewlock force-pushed the andrew/settings/4a-block-uds-windows branch from 4421414 to 213ef9c Compare October 28, 2025 18:13
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 28, 2025 •
edited by datadog-official bot
Loading

⚠️ Tests

⚠️ Warnings

❄️ 39 New flaky tests detected

IntegrationDisabled from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests (Datadog) 
Expected exit code: 0, actual exit code: 134.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests (Datadog) 
Expected exit code: 0, actual exit code: 134.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests (Datadog) 
Expected exit code: 0, actual exit code: 134.
View all

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e27c515 | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@link04 link04 Awaiting requested review from link04 link04 was automatically assigned from DataDog/apm-sdk-capabilities-dotnet

Assignees

No one assigned

Labels

type:refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock