-
Notifications
You must be signed in to change notification settings - Fork 151
Julio/fix libdd errors on v23 #7857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gleocadie/bump-to-libdatadog-21
Are you sure you want to change the base?
Julio/fix libdd errors on v23 #7857
Conversation
BenchmarksBenchmarks Report for benchmark platform 🐌Benchmarks for #7857 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ More allocations
|
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 | 6.06 KB | 6.14 KB | 81 B | 1.34% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 10.6μs | 57ns | 302ns | 0 | 0 | 0 | 5.51 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 13.7μs | 71.7ns | 336ns | 0 | 0 | 0 | 5.7 KB |
| master | StartStopWithChild |
net472 | 22.4μs | 126ns | 829ns | 0.994 | 0.331 | 0.11 | 6.06 KB |
| #7857 | StartStopWithChild |
net6.0 | 10.3μs | 57.6ns | 364ns | 0 | 0 | 0 | 5.52 KB |
| #7857 | StartStopWithChild |
netcoreapp3.1 | 14.2μs | 54.4ns | 211ns | 0 | 0 | 0 | 5.67 KB |
| #7857 | StartStopWithChild |
net472 | 22.3μs | 120ns | 637ns | 0.953 | 0.212 | 0 | 6.14 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Fewer allocations 🎉
Fewer allocations 🎉 in #7857
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
3.35 KB
3.31 KB
-46 B
-1.37%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 | 3.35 KB | 3.31 KB | -46 B | -1.37% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 944μs | 322ns | 1.25μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.04ms | 270ns | 1.04μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.21ms | 61ns | 236ns | 0 | 0 | 0 | 3.35 KB |
| #7857 | WriteAndFlushEnrichedTraces |
net6.0 | 922μs | 249ns | 964ns | 0 | 0 | 0 | 2.71 KB |
| #7857 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.03ms | 430ns | 1.66μs | 0 | 0 | 0 | 2.7 KB |
| #7857 | WriteAndFlushEnrichedTraces |
net472 | 1.23ms | 882ns | 3.42μs | 0 | 0 | 0 | 3.31 KB |
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 1.05μs | 5.98ns | 43.1ns | 0 | 0 | 0 | 1.22 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 1.39μs | 7.22ns | 36.8ns | 0 | 0 | 0 | 1.2 KB |
| master | AllCycleSimpleBody |
net472 | 1.02μs | 0.294ns | 1.1ns | 0.192 | 0 | 0 | 1.23 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 7.06μs | 37.2ns | 200ns | 0 | 0 | 0 | 4.72 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 9.07μs | 49ns | 273ns | 0 | 0 | 0 | 4.62 KB |
| master | AllCycleMoreComplexBody |
net472 | 7.71μs | 4ns | 15.5ns | 0.735 | 0 | 0 | 4.74 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 322ns | 1.72ns | 8.94ns | 0 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 397ns | 2.03ns | 8.13ns | 0 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 299ns | 0.0547ns | 0.212ns | 0.0442 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 6.22μs | 31ns | 142ns | 0 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.98μs | 40.1ns | 175ns | 0 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 6.7μs | 2.24ns | 8.39ns | 0.57 | 0 | 0 | 3.8 KB |
| #7857 | AllCycleSimpleBody |
net6.0 | 1.06μs | 5.79ns | 33.3ns | 0 | 0 | 0 | 1.22 KB |
| #7857 | AllCycleSimpleBody |
netcoreapp3.1 | 1.38μs | 0.574ns | 1.99ns | 0 | 0 | 0 | 1.2 KB |
| #7857 | AllCycleSimpleBody |
net472 | 1.03μs | 0.335ns | 1.25ns | 0.191 | 0 | 0 | 1.23 KB |
| #7857 | AllCycleMoreComplexBody |
net6.0 | 7.09μs | 26.9ns | 104ns | 0 | 0 | 0 | 4.72 KB |
| #7857 | AllCycleMoreComplexBody |
netcoreapp3.1 | 8.95μs | 44.2ns | 182ns | 0 | 0 | 0 | 4.62 KB |
| #7857 | AllCycleMoreComplexBody |
net472 | 7.61μs | 3.89ns | 14.6ns | 0.721 | 0 | 0 | 4.74 KB |
| #7857 | ObjectExtractorSimpleBody |
net6.0 | 323ns | 0.0568ns | 0.213ns | 0 | 0 | 0 | 280 B |
| #7857 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 401ns | 1.93ns | 8.18ns | 0 | 0 | 0 | 272 B |
| #7857 | ObjectExtractorSimpleBody |
net472 | 296ns | 0.0738ns | 0.286ns | 0.0438 | 0 | 0 | 281 B |
| #7857 | ObjectExtractorMoreComplexBody |
net6.0 | 6.31μs | 16.9ns | 65.4ns | 0 | 0 | 0 | 3.78 KB |
| #7857 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.76μs | 37.7ns | 151ns | 0 | 0 | 0 | 3.69 KB |
| #7857 | ObjectExtractorMoreComplexBody |
net472 | 6.7μs | 4ns | 15.5ns | 0.572 | 0 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 77.9μs | 242ns | 939ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
netcoreapp3.1 | 97.9μs | 284ns | 1.1μs | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 109μs | 19.8ns | 76.8ns | 4.93 | 0 | 0 | 32.5 KB |
| master | EncodeLegacyArgs |
net6.0 | 145μs | 201ns | 778ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 200μs | 178ns | 665ns | 0 | 0 | 0 | 2.15 KB |
| master | EncodeLegacyArgs |
net472 | 261μs | 87.9ns | 340ns | 0 | 0 | 0 | 2.16 KB |
| #7857 | EncodeArgs |
net6.0 | 77.3μs | 128ns | 496ns | 0 | 0 | 0 | 32.4 KB |
| #7857 | EncodeArgs |
netcoreapp3.1 | 96.8μs | 330ns | 1.28μs | 0 | 0 | 0 | 32.4 KB |
| #7857 | EncodeArgs |
net472 | 112μs | 56.6ns | 219ns | 5.05 | 0 | 0 | 32.51 KB |
| #7857 | EncodeLegacyArgs |
net6.0 | 143μs | 39.3ns | 152ns | 0 | 0 | 0 | 2.15 KB |
| #7857 | EncodeLegacyArgs |
netcoreapp3.1 | 199μs | 252ns | 909ns | 0 | 0 | 0 | 2.14 KB |
| #7857 | EncodeLegacyArgs |
net472 | 263μs | 149ns | 576ns | 0 | 0 | 0 | 2.16 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #7857
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1
2.436
297,405.64
724,455.88
Faster 🎉 in #7857
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1
2.059
858,209.90
416,835.45
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 | 2.436 | 297,405.64 | 724,455.88 |
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 | 2.059 | 858,209.90 | 416,835.45 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 390μs | 45.3ns | 175ns | 0 | 0 | 0 | 4.55 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 852μs | 5.43μs | 54.1μs | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 431μs | 56.4ns | 218ns | 0 | 0 | 0 | 4.66 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 284μs | 34ns | 127ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 298μs | 200ns | 775ns | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 308μs | 39.8ns | 154ns | 0 | 0 | 0 | 2.29 KB |
| #7857 | RunWafRealisticBenchmark |
net6.0 | 395μs | 91.4ns | 342ns | 0 | 0 | 0 | 4.55 KB |
| #7857 | RunWafRealisticBenchmark |
netcoreapp3.1 | 418μs | 889ns | 3.08μs | 0 | 0 | 0 | 4.48 KB |
| #7857 | RunWafRealisticBenchmark |
net472 | 427μs | 51.8ns | 201ns | 0 | 0 | 0 | 4.66 KB |
| #7857 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 286μs | 49.5ns | 192ns | 0 | 0 | 0 | 2.24 KB |
| #7857 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 689μs | 11.3μs | 113μs | 0 | 0 | 0 | 2.22 KB |
| #7857 | RunWafRealisticBenchmarkWithAttack |
net472 | 309μs | 35.4ns | 137ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 62.2μs | 305ns | 1.22μs | 0 | 0 | 0 | 14.52 KB |
| master | SendRequest |
netcoreapp3.1 | 71.4μs | 94.4ns | 353ns | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.0093ns | 0.00283ns | 0.011ns | 0 | 0 | 0 | 0 b |
| #7857 | SendRequest |
net6.0 | 60.6μs | 54.5ns | 196ns | 0 | 0 | 0 | 14.52 KB |
| #7857 | SendRequest |
netcoreapp3.1 | 72μs | 38.5ns | 149ns | 0 | 0 | 0 | 17.42 KB |
| #7857 | SendRequest |
net472 | 0.00444ns | 0.00178ns | 0.00689ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉
Fewer allocations 🎉 in #7857
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0
4 B
3 B
-1 B
-25.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472
73 B
0 b
-73 B
-100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1
1 B
0 b
-1 B
-100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472
47 B
0 b
-47 B
-100.00%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 | 4 B | 3 B | -1 B | -25.00% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 | 73 B | 0 b | -73 B | -100.00% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 | 1 B | 0 b | -1 B | -100.00% |
| Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 | 47 B | 0 b | -47 B | -100.00% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | OriginalCharSlice |
net6.0 | 1.89ms | 3.22μs | 12.5μs | 0 | 0 | 0 | 640.01 KB |
| master | OriginalCharSlice |
netcoreapp3.1 | 2.1ms | 1.4μs | 5.41μs | 0 | 0 | 0 | 640 KB |
| master | OriginalCharSlice |
net472 | 2.6ms | 107ns | 415ns | 100 | 0 | 0 | 641.95 KB |
| master | OptimizedCharSlice |
net6.0 | 1.43ms | 286ns | 1.11μs | 0 | 0 | 0 | 4 B |
| master | OptimizedCharSlice |
netcoreapp3.1 | 1.73ms | 492ns | 1.91μs | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSlice |
net472 | 1.97ms | 298ns | 1.07μs | 0 | 0 | 0 | 73 B |
| master | OptimizedCharSliceWithPool |
net6.0 | 820μs | 46.5ns | 180ns | 0 | 0 | 0 | 4 B |
| master | OptimizedCharSliceWithPool |
netcoreapp3.1 | 814μs | 171ns | 660ns | 0 | 0 | 0 | 1 B |
| master | OptimizedCharSliceWithPool |
net472 | 1.18ms | 136ns | 526ns | 0 | 0 | 0 | 47 B |
| #7857 | OriginalCharSlice |
net6.0 | 1.96ms | 4.51μs | 17.5μs | 0 | 0 | 0 | 640.01 KB |
| #7857 | OriginalCharSlice |
netcoreapp3.1 | 2.26ms | 7.83μs | 30.3μs | 0 | 0 | 0 | 640 KB |
| #7857 | OriginalCharSlice |
net472 | 2.73ms | 722ns | 2.8μs | 100 | 0 | 0 | 641.95 KB |
| #7857 | OptimizedCharSlice |
net6.0 | 1.37ms | 400ns | 1.55μs | 0 | 0 | 0 | 4 B |
| #7857 | OptimizedCharSlice |
netcoreapp3.1 | 1.75ms | 664ns | 2.57μs | 0 | 0 | 0 | 1 B |
| #7857 | OptimizedCharSlice |
net472 | 1.98ms | 339ns | 1.31μs | 0 | 0 | 0 | 0 b |
| #7857 | OptimizedCharSliceWithPool |
net6.0 | 897μs | 79.3ns | 297ns | 0 | 0 | 0 | 3 B |
| #7857 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 831μs | 181ns | 700ns | 0 | 0 | 0 | 0 b |
| #7857 | OptimizedCharSliceWithPool |
net472 | 1.18ms | 130ns | 503ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster 🎉 More allocations ⚠️
Faster 🎉 in #7857
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1
1.130
741,846.53
656,345.19
More allocations ⚠️ in #7857
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0
41.7 KB
42.82 KB
1.12 KB
2.68%
Fewer allocations 🎉 in #7857
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
56.42 KB
56.12 KB
-307 B
-0.54%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1
42.76 KB
41.97 KB
-788 B
-1.84%
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 1.130 | 741,846.53 | 656,345.19 |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 | 41.7 KB | 42.82 KB | 1.12 KB | 2.68% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 | 56.42 KB | 56.12 KB | -307 B | -0.54% |
| Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 42.76 KB | 41.97 KB | -788 B | -1.84% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 648μs | 3.63μs | 23.2μs | 0 | 0 | 0 | 41.7 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 740μs | 4.1μs | 26.6μs | 0 | 0 | 0 | 42.76 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 861μs | 1.45μs | 5.03μs | 8.33 | 0 | 0 | 56.42 KB |
| #7857 | WriteAndFlushEnrichedTraces |
net6.0 | 711μs | 3.06μs | 11.9μs | 0 | 0 | 0 | 42.82 KB |
| #7857 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 659μs | 2.15μs | 8.33μs | 0 | 0 | 0 | 41.97 KB |
| #7857 | WriteAndFlushEnrichedTraces |
net472 | 878μs | 3.29μs | 11.9μs | 8.33 | 0 | 0 | 56.12 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.91μs | 0.398ns | 1.49ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.54μs | 9.26ns | 34.7ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.86μs | 4.12ns | 15.9ns | 0.144 | 0.0144 | 0 | 987 B |
| #7857 | ExecuteNonQuery |
net6.0 | 1.88μs | 8.61ns | 34.5ns | 0 | 0 | 0 | 1.02 KB |
| #7857 | ExecuteNonQuery |
netcoreapp3.1 | 2.58μs | 9.8ns | 38ns | 0 | 0 | 0 | 1.02 KB |
| #7857 | ExecuteNonQuery |
net472 | 2.79μs | 1.26ns | 4.71ns | 0.154 | 0.014 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.74μs | 9.05ns | 47ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.21μs | 8.09ns | 30.3ns | 0 | 0 | 0 | 1.03 KB |
| master | CallElasticsearch |
net472 | 3.62μs | 3.06ns | 11.8ns | 0.162 | 0 | 0 | 1.04 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.85μs | 9.22ns | 39.1ns | 0 | 0 | 0 | 1.01 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.32μs | 11.5ns | 51.2ns | 0 | 0 | 0 | 1.08 KB |
| master | CallElasticsearchAsync |
net472 | 3.78μs | 5.84ns | 22.6ns | 0.17 | 0 | 0 | 1.1 KB |
| #7857 | CallElasticsearch |
net6.0 | 1.67μs | 0.689ns | 2.67ns | 0 | 0 | 0 | 1.03 KB |
| #7857 | CallElasticsearch |
netcoreapp3.1 | 2.23μs | 10.5ns | 42ns | 0 | 0 | 0 | 1.03 KB |
| #7857 | CallElasticsearch |
net472 | 3.49μs | 2.06ns | 7.97ns | 0.156 | 0 | 0 | 1.04 KB |
| #7857 | CallElasticsearchAsync |
net6.0 | 1.81μs | 0.468ns | 1.62ns | 0 | 0 | 0 | 1.01 KB |
| #7857 | CallElasticsearchAsync |
netcoreapp3.1 | 2.42μs | 10.9ns | 42.3ns | 0 | 0 | 0 | 1.08 KB |
| #7857 | CallElasticsearchAsync |
net472 | 3.6μs | 4.34ns | 16.8ns | 0.162 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.88μs | 8.7ns | 33.7ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.49μs | 8.26ns | 32ns | 0 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 2.55μs | 0.614ns | 2.38ns | 0.14 | 0 | 0 | 915 B |
| #7857 | ExecuteAsync |
net6.0 | 1.89μs | 4.92ns | 19ns | 0 | 0 | 0 | 952 B |
| #7857 | ExecuteAsync |
netcoreapp3.1 | 2.38μs | 9.47ns | 36.7ns | 0 | 0 | 0 | 952 B |
| #7857 | ExecuteAsync |
net472 | 2.7μs | 4.06ns | 15.7ns | 0.134 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 6.86μs | 5.86ns | 21.1ns | 0 | 0 | 0 | 2.36 KB |
| master | SendAsync |
netcoreapp3.1 | 8.71μs | 22.3ns | 86.2ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12.1μs | 6.59ns | 25.5ns | 0.484 | 0 | 0 | 3.18 KB |
| #7857 | SendAsync |
net6.0 | 6.91μs | 9.58ns | 37.1ns | 0 | 0 | 0 | 2.36 KB |
| #7857 | SendAsync |
netcoreapp3.1 | 8.52μs | 19.9ns | 77.1ns | 0 | 0 | 0 | 2.9 KB |
| #7857 | SendAsync |
net472 | 12.5μs | 13.4ns | 51.9ns | 0.498 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️
More allocations ⚠️ in #7857
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
257.86 KB
276.64 KB
18.78 KB
7.28%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
260.02 KB
274.99 KB
14.97 KB
5.76%
Fewer allocations 🎉 in #7857
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0
44.14 KB
43.78 KB
-368 B
-0.83%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472
286.72 KB
278.53 KB
-8.19 KB
-2.86%
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 | 257.86 KB | 276.64 KB | 18.78 KB | 7.28% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 | 260.02 KB | 274.99 KB | 14.97 KB | 5.76% |
| Benchmark | Base Allocated | Diff Allocated | Change | Change % |
|---|---|---|---|---|
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 | 44.14 KB | 43.78 KB | -368 B | -0.83% |
| Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 | 286.72 KB | 278.53 KB | -8.19 KB | -2.86% |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 46.9μs | 283ns | 2.71μs | 0 | 0 | 0 | 44.14 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 50.5μs | 266ns | 1.46μs | 0 | 0 | 0 | 42.64 KB |
| master | StringConcatBenchmark |
net472 | 55.8μs | 260ns | 972ns | 0 | 0 | 0 | 57.34 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 483μs | 2.01μs | 6.95μs | 0 | 0 | 0 | 260.02 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 503μs | 2.48μs | 10.2μs | 0 | 0 | 0 | 257.86 KB |
| master | StringConcatAspectBenchmark |
net472 | 406μs | 2.02μs | 8.55μs | 0 | 0 | 0 | 286.72 KB |
| #7857 | StringConcatBenchmark |
net6.0 | 42.6μs | 206ns | 848ns | 0 | 0 | 0 | 43.78 KB |
| #7857 | StringConcatBenchmark |
netcoreapp3.1 | 48μs | 285ns | 2.65μs | 0 | 0 | 0 | 42.78 KB |
| #7857 | StringConcatBenchmark |
net472 | 57.7μs | 103ns | 386ns | 0 | 0 | 0 | 57.34 KB |
| #7857 | StringConcatAspectBenchmark |
net6.0 | 485μs | 2.12μs | 7.64μs | 0 | 0 | 0 | 274.99 KB |
| #7857 | StringConcatAspectBenchmark |
netcoreapp3.1 | 532μs | 1.17μs | 4.23μs | 0 | 0 | 0 | 276.64 KB |
| #7857 | StringConcatAspectBenchmark |
net472 | 408μs | 2.13μs | 10.2μs | 0 | 0 | 0 | 278.53 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.65μs | 2.59ns | 10ns | 0 | 0 | 0 | 1.7 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.61μs | 17.4ns | 73.8ns | 0 | 0 | 0 | 1.71 KB |
| master | EnrichedLog |
net472 | 3.91μs | 3.8ns | 14.2ns | 0.253 | 0 | 0 | 1.64 KB |
| #7857 | EnrichedLog |
net6.0 | 2.67μs | 1.28ns | 4.79ns | 0 | 0 | 0 | 1.7 KB |
| #7857 | EnrichedLog |
netcoreapp3.1 | 3.66μs | 14.7ns | 56.9ns | 0 | 0 | 0 | 1.7 KB |
| #7857 | EnrichedLog |
net472 | 3.97μs | 3.85ns | 14.9ns | 0.258 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 125μs | 267ns | 1.03μs | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
netcoreapp3.1 | 127μs | 128ns | 480ns | 0 | 0 | 0 | 4.31 KB |
| master | EnrichedLog |
net472 | 167μs | 72.9ns | 283ns | 0 | 0 | 0 | 4.52 KB |
| #7857 | EnrichedLog |
net6.0 | 124μs | 97.6ns | 378ns | 0 | 0 | 0 | 4.31 KB |
| #7857 | EnrichedLog |
netcoreapp3.1 | 128μs | 195ns | 731ns | 0 | 0 | 0 | 4.31 KB |
| #7857 | EnrichedLog |
net472 | 168μs | 118ns | 457ns | 0 | 0 | 0 | 4.52 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 5.06μs | 18.4ns | 71.4ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.84μs | 21.1ns | 81.8ns | 0 | 0 | 0 | 2.26 KB |
| master | EnrichedLog |
net472 | 7.57μs | 9.61ns | 37.2ns | 0.305 | 0 | 0 | 2.08 KB |
| #7857 | EnrichedLog |
net6.0 | 4.92μs | 2.68ns | 9.66ns | 0 | 0 | 0 | 2.26 KB |
| #7857 | EnrichedLog |
netcoreapp3.1 | 6.86μs | 21.2ns | 82.1ns | 0 | 0 | 0 | 2.26 KB |
| #7857 | EnrichedLog |
net472 | 7.49μs | 5.24ns | 20.3ns | 0.299 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.93μs | 8.24ns | 31.9ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
netcoreapp3.1 | 2.65μs | 6.74ns | 26.1ns | 0 | 0 | 0 | 1.2 KB |
| master | SendReceive |
net472 | 3.18μs | 1.74ns | 6.26ns | 0.177 | 0 | 0 | 1.2 KB |
| #7857 | SendReceive |
net6.0 | 2.08μs | 8.34ns | 31.2ns | 0 | 0 | 0 | 1.2 KB |
| #7857 | SendReceive |
netcoreapp3.1 | 2.6μs | 11.9ns | 46.3ns | 0 | 0 | 0 | 1.2 KB |
| #7857 | SendReceive |
net472 | 3.17μs | 7.15ns | 27.7ns | 0.188 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.35μs | 10.8ns | 41.8ns | 0 | 0 | 0 | 1.58 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.73μs | 12.1ns | 46.8ns | 0 | 0 | 0 | 1.63 KB |
| master | EnrichedLog |
net472 | 6.74μs | 14ns | 54.2ns | 0.303 | 0 | 0 | 2.03 KB |
| #7857 | EnrichedLog |
net6.0 | 4.21μs | 9.96ns | 38.6ns | 0 | 0 | 0 | 1.58 KB |
| #7857 | EnrichedLog |
netcoreapp3.1 | 5.61μs | 13.3ns | 51.5ns | 0 | 0 | 0 | 1.63 KB |
| #7857 | EnrichedLog |
net472 | 6.66μs | 10.5ns | 40.7ns | 0.299 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 770ns | 3.51ns | 13.6ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 954ns | 5.02ns | 26.6ns | 0 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 948ns | 0.081ns | 0.303ns | 0.0907 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 918ns | 4.76ns | 22.3ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.18μs | 6.14ns | 30.1ns | 0 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 1.18μs | 0.511ns | 1.91ns | 0.1 | 0 | 0 | 658 B |
| #7857 | StartFinishSpan |
net6.0 | 766ns | 0.198ns | 0.742ns | 0 | 0 | 0 | 576 B |
| #7857 | StartFinishSpan |
netcoreapp3.1 | 987ns | 4.65ns | 18ns | 0 | 0 | 0 | 576 B |
| #7857 | StartFinishSpan |
net472 | 946ns | 0.0848ns | 0.317ns | 0.0899 | 0 | 0 | 578 B |
| #7857 | StartFinishScope |
net6.0 | 911ns | 4.46ns | 20ns | 0 | 0 | 0 | 696 B |
| #7857 | StartFinishScope |
netcoreapp3.1 | 1.21μs | 1.27ns | 4.93ns | 0 | 0 | 0 | 696 B |
| #7857 | StartFinishScope |
net472 | 1.13μs | 0.34ns | 1.27ns | 0.103 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.11μs | 5.16ns | 20ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.42μs | 7.57ns | 38.6ns | 0 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.47μs | 3.72ns | 14.4ns | 0.103 | 0 | 0 | 658 B |
| #7857 | RunOnMethodBegin |
net6.0 | 1.03μs | 5.36ns | 26.3ns | 0 | 0 | 0 | 697 B |
| #7857 | RunOnMethodBegin |
netcoreapp3.1 | 1.41μs | 2.71ns | 10.5ns | 0 | 0 | 0 | 696 B |
| #7857 | RunOnMethodBegin |
net472 | 1.42μs | 0.648ns | 2.51ns | 0.0997 | 0 | 0 | 658 B |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7857) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (76ms) : 70, 83
master - mean (75ms) : 70, 81
section Bailout
This PR (7857) - mean (81ms) : 76, 86
master - mean (79ms) : 75, 83
section CallTarget+Inlining+NGEN
This PR (7857) - mean (1,083ms) : 994, 1173
master - mean (1,060ms) : 992, 1127
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (119ms) : 112, 127
master - mean (117ms) : 111, 123
section Bailout
This PR (7857) - mean (121ms) : 113, 129
master - mean (120ms) : 114, 125
section CallTarget+Inlining+NGEN
This PR (7857) - mean (776ms) : 741, 811
master - mean (753ms) : 720, 786
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (107ms) : 99, 116
master - mean (106ms) : 100, 113
section Bailout
This PR (7857) - mean (108ms) : 102, 113
master - mean (106ms) : 100, 111
section CallTarget+Inlining+NGEN
This PR (7857) - mean (724ms) : 670, 778
master - mean (704ms) : 670, 738
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (104ms) : 98, 111
master - mean (104ms) : 97, 111
section Bailout
This PR (7857) - mean (106ms) : 99, 114
master - mean (105ms) : 99, 110
section CallTarget+Inlining+NGEN
This PR (7857) - mean (694ms) : 667, 720
master - mean (681ms) : 649, 714
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (198ms) : 187, 208
master - mean (192ms) : 188, 195
section Bailout
This PR (7857) - mean (200ms) : 193, 208
master - mean (196ms) : 192, 200
section CallTarget+Inlining+NGEN
This PR (7857) - mean (1,122ms) : 1055, 1189
master - mean (1,112ms) : 1040, 1184
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (281ms) : 274, 288
master - mean (275ms) : 270, 280
section Bailout
This PR (7857) - mean (283ms) : 273, 293
master - mean (276ms) : 272, 280
section CallTarget+Inlining+NGEN
This PR (7857) - mean (921ms) : 866, 976
master - mean (901ms) : 854, 947
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (275ms) : 265, 284
master - mean (270ms) : 265, 274
section Bailout
This PR (7857) - mean (275ms) : 267, 282
master - mean (268ms) : 266, 270
section CallTarget+Inlining+NGEN
This PR (7857) - mean (896ms) : 835, 956
master - mean (888ms) : 830, 946
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7857) - mean (277ms) : 263, 292
master - mean (269ms) : 264, 274
section Bailout
This PR (7857) - mean (273ms) : 264, 282
master - mean (268ms) : 265, 271
section CallTarget+Inlining+NGEN
This PR (7857) - mean (834ms) : 807, 861
master - mean (821ms) : 798, 844
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Summary of changes
Reason for change
Implementation details
Test coverage
Other details