-
Notifications
You must be signed in to change notification settings - Fork 151
[Profiler] Update liveheap handle limit #7872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (7872) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (76ms) : 69, 82
master - mean (76ms) : 70, 83
section Bailout
This PR (7872) - mean (81ms) : 76, 87
master - mean (79ms) : 73, 85
section CallTarget+Inlining+NGEN
This PR (7872) - mean (1,067ms) : 988, 1146
master - mean (1,067ms) : 976, 1158
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (118ms) : 112, 124
master - mean (118ms) : 111, 125
section Bailout
This PR (7872) - mean (118ms) : 113, 124
master - mean (118ms) : 111, 125
section CallTarget+Inlining+NGEN
This PR (7872) - mean (761ms) : 716, 805
master - mean (758ms) : 720, 796
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (103ms) : 97, 109
master - mean (105ms) : 98, 111
section Bailout
This PR (7872) - mean (105ms) : 100, 111
master - mean (107ms) : 100, 114
section CallTarget+Inlining+NGEN
This PR (7872) - mean (710ms) : 658, 763
master - mean (719ms) : 677, 762
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (102ms) : 96, 109
master - mean (106ms) : 98, 114
section Bailout
This PR (7872) - mean (105ms) : 99, 111
master - mean (105ms) : 98, 112
section CallTarget+Inlining+NGEN
This PR (7872) - mean (685ms) : 655, 716
master - mean (690ms) : 661, 720
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (198ms) : 189, 207
master - mean (195ms) : 192, 198
section Bailout
This PR (7872) - mean (202ms) : 194, 209
master - mean (198ms) : 196, 201
section CallTarget+Inlining+NGEN
This PR (7872) - mean (1,181ms) : 1110, 1253
master - mean (1,129ms) : 1071, 1188
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (292ms) : 282, 303
master - mean (280ms) : 276, 285
section Bailout
This PR (7872) - mean (295ms) : 284, 306
master - mean (281ms) : 276, 287
section CallTarget+Inlining+NGEN
This PR (7872) - mean (975ms) : 933, 1016
master - mean (924ms) : 880, 969
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (283ms) : 273, 293
master - mean (274ms) : 267, 280
section Bailout
This PR (7872) - mean (282ms) : 273, 291
master - mean (275ms) : 270, 279
section CallTarget+Inlining+NGEN
This PR (7872) - mean (944ms) : 875, 1012
master - mean (902ms) : 860, 944
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7872) - mean (278ms) : 271, 285
master - mean (273ms) : 267, 278
section Bailout
This PR (7872) - mean (279ms) : 270, 288
master - mean (273ms) : 269, 276
section CallTarget+Inlining+NGEN
This PR (7872) - mean (871ms) : 839, 903
master - mean (839ms) : 813, 865
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Make the number of monitored live objects customizable via environment variable and change the default value to 4096
Reason for change
The current 1024 maximum was to small especially in case of memory leak
Implementation details
Add the corresponding env var helpers in the configuration and use it in the
LiveObjectsProviderTest coverage
Tests have been added
Other details