Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reuse github service containers for orchestrion tests #3229

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rarguelloF
Copy link
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 25, 2025

Datadog Report

Branch report: rarguelloF/orchestrion-reuse-containers
Commit report: b749ad7
Test service: dd-trace-go

❌ 2 Failed (0 Known Flaky), 5342 Passed, 73 Skipped, 2m 51.27s Total Time

❌ Failed Tests (2)

  • TestTracerRuntimeMetrics - gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer - Details

    Expand for error
     Failed
     
     === RUN   TestTracerRuntimeMetrics
     --- FAIL: TestTracerRuntimeMetrics (0.02s)
    
  • TestTracerRuntimeMetrics/dd-env - gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer - Details

    Expand for error
     Failed
     
     === RUN   TestTracerRuntimeMetrics/dd-env
         tracer_test.go:726: 
             	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/ddtrace/tracer/tracer_test.go:726
             	Test:       	TestTracerRuntimeMetrics/dd-env
         --- FAIL: TestTracerRuntimeMetrics/dd-env (0.01s)
    

@pr-commenter
Copy link

pr-commenter bot commented Feb 25, 2025

Benchmarks

Benchmark execution time: 2025-02-25 17:06:12

Comparing candidate commit 9db52fe in PR branch rarguelloF/orchestrion-reuse-containers with baseline commit 386c125 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 1 unstable metrics.

@darccio
Copy link
Member

darccio commented Mar 10, 2025

@rarguelloF As part of our upcoming release, we are reviewing all in-flight PRs. Please consider closing it or rebasing to v2-dev if you want to merge it for the next release after v2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants