-
Notifications
You must be signed in to change notification settings - Fork 319
Move macrobenchmarks to apm-sdks-benchmarks repo
#10066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sarahchen6
wants to merge
18
commits into
master
Choose a base branch
from
sarahchen6/move-macrobenchmarks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f391147 to
9602f73
Compare
ba1ae21 to
b376785
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095140
Total [baseline] (8.78 s) : 0, 8779619
Agent [candidate] (1.081 s) : 0, 1080842
Total [candidate] (8.73 s) : 0, 8729522
section iast
Agent [baseline] (1.222 s) : 0, 1221660
Total [baseline] (9.412 s) : 0, 9412395
Agent [candidate] (1.233 s) : 0, 1232758
Total [candidate] (9.413 s) : 0, 9412813
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (658.567 ms) : 0, 658567
BytebuddyAgent [candidate] (648.938 ms) : 0, 648938
GlobalTracer [baseline] (284.658 ms) : 0, 284658
GlobalTracer [candidate] (282.037 ms) : 0, 282037
AppSec [baseline] (33.069 ms) : 0, 33069
AppSec [candidate] (32.46 ms) : 0, 32460
Debugger [baseline] (68.152 ms) : 0, 68152
Debugger [candidate] (67.134 ms) : 0, 67134
Remote Config [baseline] (654.043 µs) : 0, 654
Remote Config [candidate] (654.225 µs) : 0, 654
Telemetry [baseline] (9.155 ms) : 0, 9155
Telemetry [candidate] (9.105 ms) : 0, 9105
Flare Poller [baseline] (3.758 ms) : 0, 3758
Flare Poller [candidate] (3.755 ms) : 0, 3755
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (790.521 ms) : 0, 790521
BytebuddyAgent [candidate] (796.04 ms) : 0, 796040
GlobalTracer [baseline] (255.63 ms) : 0, 255630
GlobalTracer [candidate] (259.356 ms) : 0, 259356
IAST [baseline] (26.762 ms) : 0, 26762
IAST [candidate] (27.344 ms) : 0, 27344
AppSec [baseline] (34.538 ms) : 0, 34538
AppSec [candidate] (34.466 ms) : 0, 34466
Debugger [baseline] (65.081 ms) : 0, 65081
Debugger [candidate] (66.05 ms) : 0, 66050
Remote Config [baseline] (566.886 µs) : 0, 567
Remote Config [candidate] (578.733 µs) : 0, 579
Telemetry [baseline] (8.439 ms) : 0, 8439
Telemetry [candidate] (8.581 ms) : 0, 8581
Flare Poller [baseline] (3.478 ms) : 0, 3478
Flare Poller [candidate] (3.596 ms) : 0, 3596
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084117
Total [baseline] (10.804 s) : 0, 10803982
Agent [candidate] (1.084 s) : 0, 1084050
Total [candidate] (11.017 s) : 0, 11017011
section appsec
Agent [baseline] (1.273 s) : 0, 1272852
Total [baseline] (11.137 s) : 0, 11137473
Agent [candidate] (1.266 s) : 0, 1266401
Total [candidate] (10.923 s) : 0, 10923174
section iast
Agent [baseline] (1.222 s) : 0, 1221512
Total [baseline] (11.245 s) : 0, 11245256
Agent [candidate] (1.232 s) : 0, 1232214
Total [candidate] (11.248 s) : 0, 11247963
section profiling
Agent [baseline] (1.218 s) : 0, 1217831
Total [baseline] (10.865 s) : 0, 10865045
Agent [candidate] (1.204 s) : 0, 1203921
Total [candidate] (10.944 s) : 0, 10943645
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (650.488 ms) : 0, 650488
BytebuddyAgent [candidate] (650.497 ms) : 0, 650497
GlobalTracer [baseline] (282.52 ms) : 0, 282520
GlobalTracer [candidate] (282.453 ms) : 0, 282453
AppSec [baseline] (32.5 ms) : 0, 32500
AppSec [candidate] (32.558 ms) : 0, 32558
Debugger [baseline] (68.217 ms) : 0, 68217
Debugger [candidate] (68.185 ms) : 0, 68185
Remote Config [baseline] (651.585 µs) : 0, 652
Remote Config [candidate] (678.081 µs) : 0, 678
Telemetry [baseline] (9.134 ms) : 0, 9134
Telemetry [candidate] (9.147 ms) : 0, 9147
Flare Poller [baseline] (3.741 ms) : 0, 3741
Flare Poller [candidate] (3.783 ms) : 0, 3783
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (692.832 ms) : 0, 692832
BytebuddyAgent [candidate] (689.495 ms) : 0, 689495
GlobalTracer [baseline] (260.448 ms) : 0, 260448
GlobalTracer [candidate] (259.097 ms) : 0, 259097
AppSec [baseline] (176.156 ms) : 0, 176156
AppSec [candidate] (174.698 ms) : 0, 174698
Debugger [baseline] (67.659 ms) : 0, 67659
Debugger [candidate] (68.129 ms) : 0, 68129
Remote Config [baseline] (745.591 µs) : 0, 746
Remote Config [candidate] (733.929 µs) : 0, 734
Telemetry [baseline] (9.243 ms) : 0, 9243
Telemetry [candidate] (9.063 ms) : 0, 9063
Flare Poller [baseline] (3.975 ms) : 0, 3975
Flare Poller [candidate] (3.78 ms) : 0, 3780
IAST [baseline] (24.836 ms) : 0, 24836
IAST [candidate] (24.553 ms) : 0, 24553
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (789.387 ms) : 0, 789387
BytebuddyAgent [candidate] (796.455 ms) : 0, 796455
GlobalTracer [baseline] (255.605 ms) : 0, 255605
GlobalTracer [candidate] (257.761 ms) : 0, 257761
AppSec [baseline] (35.178 ms) : 0, 35178
AppSec [candidate] (35.276 ms) : 0, 35276
Debugger [baseline] (65.187 ms) : 0, 65187
Debugger [candidate] (66.162 ms) : 0, 66162
Remote Config [baseline] (553.447 µs) : 0, 553
Remote Config [candidate] (548.008 µs) : 0, 548
Telemetry [baseline] (8.475 ms) : 0, 8475
Telemetry [candidate] (8.525 ms) : 0, 8525
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.507 ms) : 0, 3507
IAST [baseline] (26.995 ms) : 0, 26995
IAST [candidate] (27.201 ms) : 0, 27201
section profiling
ProfilingAgent [baseline] (97.065 ms) : 0, 97065
ProfilingAgent [candidate] (97.207 ms) : 0, 97207
crashtracking [baseline] (1.232 ms) : 0, 1232
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (710.516 ms) : 0, 710516
BytebuddyAgent [candidate] (701.56 ms) : 0, 701560
GlobalTracer [baseline] (223.082 ms) : 0, 223082
GlobalTracer [candidate] (220.399 ms) : 0, 220399
AppSec [baseline] (32.703 ms) : 0, 32703
AppSec [candidate] (31.963 ms) : 0, 31963
Debugger [baseline] (68.939 ms) : 0, 68939
Debugger [candidate] (68.316 ms) : 0, 68316
Remote Config [baseline] (660.647 µs) : 0, 661
Remote Config [candidate] (618.248 µs) : 0, 618
Telemetry [baseline] (8.983 ms) : 0, 8983
Telemetry [candidate] (9.132 ms) : 0, 9132
Flare Poller [baseline] (3.829 ms) : 0, 3829
Flare Poller [candidate] (3.784 ms) : 0, 3784
Profiling [baseline] (97.667 ms) : 0, 97667
Profiling [candidate] (97.769 ms) : 0, 97769
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1177, 1200
. : milestone, 1189,
iast (3.255 ms) : 3209, 3300
. : milestone, 3255,
iast_FULL (5.767 ms) : 5711, 5824
. : milestone, 5767,
iast_GLOBAL (3.655 ms) : 3603, 3708
. : milestone, 3655,
profiling (2.104 ms) : 2085, 2124
. : milestone, 2104,
tracing (1.784 ms) : 1769, 1799
. : milestone, 1784,
section candidate
no_agent (1.225 ms) : 1212, 1238
. : milestone, 1225,
iast (3.299 ms) : 3251, 3347
. : milestone, 3299,
iast_FULL (5.634 ms) : 5578, 5689
. : milestone, 5634,
iast_GLOBAL (3.617 ms) : 3564, 3669
. : milestone, 3617,
profiling (1.969 ms) : 1953, 1986
. : milestone, 1969,
tracing (1.848 ms) : 1830, 1866
. : milestone, 1848,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section baseline
no_agent (18.038 ms) : 17855, 18221
. : milestone, 18038,
appsec (18.74 ms) : 18548, 18932
. : milestone, 18740,
code_origins (17.731 ms) : 17554, 17907
. : milestone, 17731,
iast (17.621 ms) : 17446, 17796
. : milestone, 17621,
profiling (18.414 ms) : 18231, 18597
. : milestone, 18414,
tracing (18.57 ms) : 18384, 18756
. : milestone, 18570,
section candidate
no_agent (19.436 ms) : 19235, 19636
. : milestone, 19436,
appsec (18.691 ms) : 18499, 18883
. : milestone, 18691,
code_origins (17.673 ms) : 17499, 17847
. : milestone, 17673,
iast (17.61 ms) : 17433, 17787
. : milestone, 17610,
profiling (18.691 ms) : 18506, 18876
. : milestone, 18691,
tracing (17.704 ms) : 17529, 17879
. : milestone, 17704,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.683 ms) : 3469, 3896
. : milestone, 3683,
iast (2.235 ms) : 2170, 2300
. : milestone, 2235,
iast_GLOBAL (2.276 ms) : 2211, 2342
. : milestone, 2276,
profiling (2.086 ms) : 2033, 2139
. : milestone, 2086,
tracing (2.061 ms) : 2010, 2112
. : milestone, 2061,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (2.48 ms) : 2428, 2532
. : milestone, 2480,
iast (2.232 ms) : 2167, 2296
. : milestone, 2232,
iast_GLOBAL (2.27 ms) : 2205, 2335
. : milestone, 2270,
profiling (2.081 ms) : 2028, 2134
. : milestone, 2081,
tracing (2.063 ms) : 2012, 2114
. : milestone, 2063,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1b6bc245d4, baseline=1.57.0-SNAPSHOT~0f79569cdb
dateFormat X
axisFormat %s
section baseline
no_agent (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
appsec (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
iast (18.304 s) : 18304000, 18304000
. : milestone, 18304000,
iast_GLOBAL (17.858 s) : 17858000, 17858000
. : milestone, 17858000,
profiling (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
tracing (14.656 s) : 14656000, 14656000
. : milestone, 14656000,
section candidate
no_agent (15.429 s) : 15429000, 15429000
. : milestone, 15429000,
appsec (14.459 s) : 14459000, 14459000
. : milestone, 14459000,
iast (17.963 s) : 17963000, 17963000
. : milestone, 17963000,
iast_GLOBAL (17.821 s) : 17821000, 17821000
. : milestone, 17821000,
profiling (14.661 s) : 14661000, 14661000
. : milestone, 14661000,
tracing (14.833 s) : 14833000, 14833000
. : milestone, 14833000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Now that our macrobenchmarks have been moved to the
apm-sdks-benchmarksrepo (https://github.com/DataDog/apm-sdks-benchmarks/pull/34), we can remove the local implementation.Motivation
Additional Notes
To check this, see the manually triggered macrobenchmark runs in CI: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/86577685. Note that we'll have to confirm that they're automatically run on
masterand when scheduled (ref).Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-715